Any help on this one ?

Question about the task

Under discussion

package com.codegym.task.task07.task0712;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayList;

/*
Shortest or longest

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        //write your code here
        ArrayList<String> list = new ArrayList<String>();
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
         int lng = 0;
         int shrt = 0;

        for(int i = 0; i < 10; i ++){
            String s=reader.readLine();
            list.add(s);
        }


        String shortest = list.get(0);
        for(int i=0; i<10; i++){

            if (list.get(i).length()<shortest.length())

                shortest = list.get(i);
                shrt = i;
}

        String longest = list.get(0);
        for(int i =0; i<10; i++){
          if (list.get(i).length()>longest.length())
              longest = list.get(i);
              lng = i;
        }

        if (shrt<lng)
            System.out.println(list.get(shrt));
        else
            System.out.println(list.get(lng));





    }
}

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list = new ArrayList<String>(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int lng = 0; int shrt = 0; for(int i = 0; i < 10; i ++){ String s=reader.readLine(); list.add(s); } String shortest = list.get(0); for(int i=0; i<10; i++){ } if (list.get(i).length()<shortest.length()) shortest = list.get(i); shrt = i; String longest = list.get(0); for(int i =0; i<10; i++){ if (list.get(i).length()>longest.length()) longest = list.get(i); lng = i; } if (shrt<lng) System.out.println(list.get(shrt)); else System.out.println(list.get(lng)); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

6 November 2019, 19:42

useful

A few mistakes: Lines 28 and 29, the curly brackets for that loop have no code in them. The loop does nothing. The if statements at lines 30 and 38 have no curly brackets. It is best if you enclose the code you want run inside curly brackets to reduce risk of bugs, which this code does have without those brackets. The code works fine otherwise, after these fixes are applied.

Зоран Јањић

Level 8 , Teslic, Serbia

9 November 2019, 15:39

Im getting this now The program should display the longest string if it comes before the shortest. public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list = new ArrayList<String>(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int lng = 0; int shrt = 0; for(int i = 0; i < 10; i ++){ String s=reader.readLine(); list.add(s); } String shortest = list.get(0); for(int i=0; i<10; i++){ if (list.get(i).length()<shortest.length()){ shortest = list.get(i); shrt = i; } } String longest = list.get(0); for(int i =0; i<10; i++){ if (list.get(i).length()>longest.length()) longest = list.get(i); lng = i; } if (shrt<lng){ System.out.println(list.get(shrt));} else System.out.println(list.get(lng)); } }

Guadalupe Gagnon

Level 37 , Tampa, United States

9 November 2019, 16:55

the if statement inside the loop trying to determine the 'longest' is missing curly brackets. This is the only problem that I find with your code. After fixing this you should pass. A couple tips: #1 When you set shortest and longest to 'list.get(0)', in the following loops you should start them at 1 instead of 0. That is because you don't need to compare the string against itself: String longest = list.get(0); for(int i =1; i<10; i++){ #2 get in the habit of using the arrays length in the for loops when looping through collections. Just using 10 (or any number) is hardcoding in the length and could be a problem later on. Lets say that you misread the requirements and the array was supposed to be 15 strings long, You would have to change every single one of your for loops to reflect this. However if instead you used:

for (int i = 0; i < list.size(); i++) {

You would only have to change one place in your code without breaking the rest. In this particular task it would be a quite minor inconvenience to make a change; but if you were working on a large project that had thousands of lines of code in different classes, packages, etc... Trust me, you would throw your computer through a wall if the client changed it from 10 to 15 and you had to make all those little changes.