I'm receiving the correct answer, but verification unsuccessful.

Question about the task

Archived

The output is coming correct as expected, but the task is not getting passed. Please let me know the issue is the code and what needs to be corrected

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings = new ArrayList<String> (); public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader (new InputStreamReader(System.in)); for (int i = 0; i < 5; i++) strings.add(reader.readLine()); int listsize = strings.size(); String longestString = strings.get(0); for (int i = 1; i < strings.size()-1; i++) { String s = strings.get(i); if (longestString.length() <= s.length()) { System.out.println(longestString ) ; longestString = s; System.out.println(longestString ) ; } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Lakshmanan Subramanian

Level 16 , United States

12 November 2019, 13:11

Thanks for the help Anthony chalk and Guadalupe Gagnon

Lakshmanan Subramanian

Level 16 , United States

12 November 2019, 01:32

Thanks for your response. I have tried as below as you suggested, but still not getting thru package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings = new ArrayList<String> (); public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> strings = new ArrayList<String> (); for (int i=0; i < 5; i++) strings.add(reader.readLine()); // String s = strings.get(0);; int m = strings.get(0).length(); for (int j=1; j<strings.size(); j++){ if (m < strings.get(j).length()) m = strings.get(j).length(); } for (int j=0; j<strings.size(); j++){ if (strings.get(j).length() == m) { System.out.println(strings.get(j)); } } } }

Guadalupe Gagnon

Level 37 , Tampa, United States

12 November 2019, 03:31

solution

#1 line 14 will fail the task. Change it back to the original and create a new object for it inside the main method

public class Solution {
    private static List<String> strings;

    public static void main(String[] args) throws Exception {
        strings = new ArrayList<String> ();

Anthony Chalk

Level 30 , London, United Kingdom

12 November 2019, 00:29

useful

Line 31, you're displaying the shorter of the two strings. Also, before you start displaying anything you should first find the longest element, the way you're currently approaching this task you'll display the longer of the two elements being compared but that might not be the longest element in the ArrayList. Try one using one loop to find the longest element and then a second loop to display that element and all other elements of equal length