Can't pass openTile conditions

Question about the task

Resolved

All works as expected, i tired passing both x,y and y,x and both work perfectly (as the game should) but i cannot pass the two openTile conditions. Any help is appreciated. I also tried leaving everything x,y except gameField[y][x].isMine and still no luck.

private void openTile(int y, int x) {
    // display a mine in the cell if it's a mine
    if (gameField[y][x].isMine)
    {
        this.setCellValue(y, x, MINE);
        this.setCellColor(y, x, Color.RED);
    }
    // display the # of mined neighbors if not a mine in cell
    else
    {
        this.setCellNumber(y, x, gameField[y][x].countMineNeighbors);
        this.setCellColor(y, x, Color.GREEN);
    }
    // set the status of the cell to open
    gameField[y][x].isOpen = true;
}

At this stage, we'll deal with the logic to reveal cells. Let's create a corresponding method and a variable that will store the cell state (revealed or hidden).

When revealing a cell, the method will:

- draw a mine in the cell if it contains a mine;
- display the number of mined neighbors if the cell does not contain a mine;
- mark the cell as revealed in the model;
- change the cell color.

For convenience, we suggest adding the mine symbol to a separate constant. When the a cell be revealed? Correct! When you click on it with the left mouse button. To handle this click event, the engine has a special method: onMouseLeftClick(int, int).

Let's override it in our class. It will call the method that reveals a cell.

And, of course, run the program and enjoy the results of your work.

Requirements:

The MinesweeperGame class must have a private static final String MINE field that is initialized when it is declared. For example, you can use the UTF-16 symbol for a bomb: "\uD83D\uDCA3".
The MinesweeperGame class must have a private void openTile(int x, int y) method.
The openTile(int, int) method must draw MINE if the gameObject at the passed coordinates is a mine. Use the setCellValue(int, int, String) method.
The openTile(int, int) method must draw the number of adjacent mines if the gameObject at the passed coordinates is not a mine. Use the setCellNumber(int, int, int) method.
The GameObject class must have a public boolean isOpen field.
The openTile(int, int) method should set the isOpen field on the gameField element equal to true and use the setCellColor(int, int, Color) method to draw the cell background. For example, using Color.GREEN.
The MinesweeperGame class must override the Game parent class's onMouseLeftClick(int, int) method.
The onMouseLeftClick(int, int) method must call the openTile(int, int) method.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class MinesweeperGame extends Game { private static final int SIDE = 9; private int countMinesOnField; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private static final String MINE = "\uD83D\uDCA3"; public void initialize() { this.setScreenSize (SIDE, SIDE); createGame(); } private void createGame() { int numMines = 0; for (int x=0; x<SIDE; x++) { for (int y=0; y<SIDE; y++) { this.setCellColor(x, y, Color.ORANGE); if (this.getRandomNumber(10) == 1) { gameField[y][x] = new GameObject(x, y, true); numMines++; } else gameField[y][x] = new GameObject(x, y, false); } } countMinesOnField = numMines; countMineNeighbors(); } private void countMineNeighbors() { for (int x=0; x<SIDE; x++) for (int y=0; y<SIDE; y++) if (gameField[y][x].isMine == false) getNeighbors(gameField[y][x]); } private void getNeighbors(GameObject GameObject) { GameObject.countMineNeighbors = 0; // cell to left checked if viable if (GameObject.x-1 >= 0) if (gameField[GameObject.y][GameObject.x-1].isMine) GameObject.countMineNeighbors++; // cell to right checked if viable if (GameObject.x+1 < SIDE) if (gameField[GameObject.y][GameObject.x+1].isMine) GameObject.countMineNeighbors++; // above row cells checked if viable if (GameObject.y-1 >= 0) { if (gameField[GameObject.y-1][GameObject.x].isMine) GameObject.countMineNeighbors++; if (GameObject.x-1 >= 0) if (gameField[GameObject.y-1][GameObject.x-1].isMine) GameObject.countMineNeighbors++; if (GameObject.x+1 < SIDE) if (gameField[GameObject.y-1][GameObject.x+1].isMine) GameObject.countMineNeighbors++; } // below row cells checked if viable if (GameObject.y+1 < SIDE) { if (gameField[GameObject.y+1][GameObject.x].isMine) GameObject.countMineNeighbors++; if (GameObject.x-1 >= 0) if (gameField[GameObject.y+1][GameObject.x-1].isMine) GameObject.countMineNeighbors++; if (GameObject.x+1 < SIDE) if (gameField[GameObject.y+1][GameObject.x+1].isMine) GameObject.countMineNeighbors++; } } private void openTile(int y, int x) { // display a mine in the cell if it's a mine if (gameField[y][x].isMine) { this.setCellValue(y, x, MINE); this.setCellColor(y, x, Color.RED); } // display the # of mined neighbors if not a mine in cell else { this.setCellNumber(y, x, gameField[y][x].countMineNeighbors); this.setCellColor(y, x, Color.GREEN); } // set the status of the cell to open gameField[y][x].isOpen = true; } @Override public void onMouseLeftClick(int y, int x) { openTile(y, x); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Hoist

Level 35 , San Diego, United States

5 March 2023, 02:15

I might still be mixed up - but I think you start thinking of a grid in the upper left hand corner at 0/0 then go across first -- which is x - the horizontal or row ? Correct if wrong pls. Read the first few pages on Array's in Code Gym

Guadalupe Gagnon

Level 37 , Tampa, United States

17 November 2019, 05:15

looks like your x/y's are mixed up. Array indexing has uses y-x to access, while the methods use geometric coordinates x-y. You need to make sure you use the proper format for each.

Ashish RajAnand

Level 13 , Bhilai , India

8 March 2020, 04:04

Sir please tell me why method are using x-y coordinates and array index uses y-x to access? when we create array of gameField object we always access to y,x but we using loop as y then x so it is normal

Hoist

Level 35 , San Diego, United States

5 March 2023, 02:12

Check this out. Using Y - X coordinates. Row / Column vs Height Width then Array vs Method Arranging elements in arrays: (x, y) or (y, x) See Page here: https://codegym.cc/quests/lectures/en.questsyntaxpro.level05.lecture04.story