Code works but not passing

Question about the task

Under discussion

It is beginning to get annoying how often this happens. If they have further requirements, why not just list them? That is the point of test-driven development. Any thoughts as to what the other unlisted requirements are? Thanks!

package com.codegym.task.task04.task0420; /* Sorting three numbers */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); int b = Integer.parseInt(reader.readLine()); int c = Integer.parseInt(reader.readLine()); int first = 0; int second = 0; int third = 0; if (a > b && a > c ) { first = a; } if (a > b && a < c) { second = a; third = b; } if (b > a && b > c) { first = b; } if (b > a && b < c) { second = b; third = a; } if (c > a && c > b) { first = c; } if (c > a && c < b) { second = c; third = a; } System.out.println(first + " " + second + " " + third); } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Anthony Chalk

Level 30 , London, United Kingdom

20 November 2019, 16:48

useful

Try rewriting the conditions that each time you assign values to each of "first", "second", and "third". You also might want to use <= and >= instead of < and >, otherwise what would happen if you entered two of the same number?

Anthony Chalk

Level 30 , London, United Kingdom

20 November 2019, 16:52

useful

something on the lines of

if (a>=b && b>=c){
first = a;
second = b;
third = c;
}
else if (a>=b && c>=b){
first = a;
second = c;
third = b;
}

etc

Dave Andrea

Level 41 , Canada

20 November 2019, 17:30

Thanks! I will give that a try.

Guadalupe Gagnon

Level 37 , Tampa, United States

20 November 2019, 16:34

useful

This code is bugged. I entered 2, 3, 1 and the output was 3 0 0. Also any time i enter 3 numbers where any are equal i get strange results.

Dave Andrea

Level 41 , Canada

20 November 2019, 17:29

Yes, I didn't enter anything for edge cases because it didn't ask for it. I wish you could actually see the tests they use to verify your code. It would make the debugging a lot easier (and you would learn to be more strict about considering edge cases). How do you enter your own input to test your program? Can this be done from the online IDE, or only through IDEA?

Guadalupe Gagnon

Level 37 , Tampa, United States

20 November 2019, 17:42

IDEA is definitely the preferred way to code. But if not:

At the bottom of the online compiler you can change the input data there.

Guadalupe Gagnon

Level 37 , Tampa, United States

20 November 2019, 17:56

I have actually suggested to the codegym creators that it would be infinitely helpful if they provided a set of input data with the correct expected results, something like 5-6 different 'tests', but as of yet they have not. Since I have started on Codegym (september/October 2018) they have fixed a lot of bugs and improved other aspects a lot. There were actually tasks that could not be completed when I had started do to verification bugs. I wanted to pull my own hair out on so many of the tasks because I wasn't sure if I had a bug in my code or they had a bug in their system. Now, unless new bugs get introduced in later page updates, I can say there shouldn't be any actual bugs in the verification. The best things I can recommend are: #1 keep your code as simple as possible. While you may know more than what has been taught up to your level, and can use that knowledge to complete tasks, the tasks were (mostly) designed to be completed by what has been taught. #2 Read the conditions/requirements thoroughly. I a lot help posts where the only thing wrong in the code is that they didn't follow the instructions. Maybe it says to sort in ascending order instead of descending order, or only print the first/last item in a list that matches a certain criteria instead of all items, swapping the order of user input from what the conditions say etc. #3 When output is needed, copy and paste it directly from the conditions. That is another reason I see a lot of help posts. The task will say to output something like: "Guadalupe over explains things on the help boards!" and their output will be: "Guadalupe over explains things on the help boards" < missing ! at the end #4 Don't be afraid to google things and copy/paste what you find. Now using google like this "answer to task 0405" isn't what i mean, but "Bubble sort java" would be appropriate. Then just modify what you find to suit your need. You will learn a lot doing this.