The last requirement is failing all the time.

Question about the task

Under discussion

Nothing is working. I tried the following - 1. Incrementing the countMinesOnField within the createGame method. 2. Using a local variable to count and then assigning its value to countMinesOnField in createGame method. 3. Using a local variable to count and then assigning its value to countMinesOnField in initialize method. 4. Using "this.countMinesOnField" and "countMinesOnField " in all the above 3 scenarios. Any pointers?

Minesweeper is aptly named. The player has to deal with mines, though maybe it would be best for the player to stay far away from them :)

Let's add these mines to the game. To do this, we'll adapt the GameObject class to account for the fact that a cell can be a mine (by adding the isMine flag).

Don't create a new constructor: editing the existing constructor will suffice.

Additionally, when creating the cells, add code that generates mines with a probability of 10%. The easiest way is to use the Game class's getRandomNumber(int n) method, which returns a random number from 0 to n-1 inclusive. Therefore, the probability of generating a certain number is 1/n.

And don't forget to count the number of generated mines in the MinesweeperGame class.

Once you've done all that, run the program and check that nothing is broken :)

Requirements:

The GameObject class must have a public boolean isMine field.
The GameObject class must have one constructor with (int, int, boolean) parameters that are used to initialize the x, y, and isMine fields, in that order.
There must be a private int countMinesOnField variable in the MinesweeperGame class.
When cells are created in the createGame() method, you should randomly determine whether each cell will have a mine. Use the Game class's getRandomNumber(int) method with the argument 10.
After the createGame() method is executed, the countMinesOnField variable should be assigned the value of the number of mines in the field.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class MinesweeperGame extends Game { private static final int SIDE = 9; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField; public void initialize() { //Setting the field size as 9 X 9 cells setScreenSize(SIDE,SIDE); createGame(); } private void createGame() { boolean putMine = false; int totalMines = 0; for(int i = 0; i < SIDE; i++) { for(int j = 0; j < SIDE; j++) { putMine = (getRandomNumber(10) == 1); gameField[i][j] = new GameObject(j,i,putMine); //increment the total mines count by 1 if the cell is initiated with a mine totalMines = (putMine)? totalMines++ : totalMines; setCellColor(i,j,Color.ORANGE); } } this.countMinesOnField = totalMines; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

16 December 2019, 17:08

change line 30 to: if(putMine) totalMines++; Also line 32 has i and j backwards. At this point to actually will not affect the game because it will still set all the cells to Orange, but make sure not to do that in more crucial parts of the game.

Level 15 , Bodmin, United Kingdom

18 December 2019, 23:39

Thanks Guadalupe... It worked. Just wondering what's wrong with my logic though... It will still count the total mines with my logic as well. But I agree that only a single "if" will work and I don't need if and else.

Guadalupe Gagnon

Level 37 , Tampa, United States

19 December 2019, 14:24

Looking at your code I would assume it does the same thing, however testing it found different behavior. Run this bit of code and see the difference:

public class Solution {
    public static void main(String[] args) throws IOException {
        int count1 = 0, count2 = 0;

        for (int i = 0; i < 10; i++) {
            // adds 1 to count1 when i % 2 == 0
            if (i % 2 == 0) count1++;

            // adds 1 to count2 when i % 2 == 0
            count2 = (i % 2 == 0) ? count2++ : count2;
        }

        // both count1 and count2 should be 5
        System.out.println("Final value of count1: " + count1);
        System.out.println("Final value of count2: " + count2);

    }
}

Level 15 , Bodmin, United Kingdom

19 December 2019, 15:03

Wow!!! Nice idea to compare the solution. I now found the issue - I should have used ++count2 instead of count2++ I guess we discovered a good exercise to explain the difference between pre and post increment operator ;)