Am I misunderstanding the question? I think this should be correct

Question about the task

Checking the order

Java Syntax, Level 7, Lesson 9

Resolved

I think my solution is correct, or am I not understanding this right?

1. Read 10 words from the keyboard and add them to a list of strings.
2. Determine whether the list is ordered by increasing string length.
3. If it is not, then display the index of the first element that violates this order.

Requirements:

Declare a string list variable and immediately initialize it.
Read 10 lines from the keyboard and add them to the list.
If the list is ordered by increasing string length, then you don't need to display anything.
If the list is not ordered by increasing string length, then display the index of the first element that violates this order.

package com.codegym.task.task07.task0718; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.Scanner; /* Checking the order */ public class Solution { public static void main(String[] args) throws IOException { //write your code here ArrayList<String> list = new ArrayList<String>(); Scanner scan = new Scanner(System.in); int length = 0; boolean ordered = true; int violator = 0; for (int i = 0; i < 10; i++) { String s = scan.next(); list.add(s); if (length <= s.length()) { length = s.length(); } else if (length > s.length() && ordered) { violator = i; ordered = false; //break; } } if (!ordered) { System.out.println(list.get(violator)); } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

17 December 2019, 21:15

solution

if (length <= s.length()){
   length = s.length();
 } else if (length > s.length() && ordered) {// this if statement is the exact opposite of the one 2 lines above
   violator = i;
   ordered = false;
}

Try scan.nextLine(), this is your problem. It is also correct to be outputting the index number and not the value at the index number. I noted in the code I shared above that (length <= s.length()) and (length > s.length()) are polar opposites and you do not need to use the second one. Logically if the first one is false then the second one is true every time (and same when 1st is true the 2nd will be false).

oli blaustrom

Level 18 , Luzern, Switzerland

18 December 2019, 18:10

thank you @guadalupe that worked. I thought scan.nextLine I only need if there is an empty input. Can you share why this caused the error? thanks for the pointer in logic too, I didn't even notice that lol!

Guadalupe Gagnon

Level 37 , Tampa, United States

18 December 2019, 18:31

useful

public class Solution {
    public static void main(String[] args) throws IOException {
        //write your code here
        ArrayList<String> list = new ArrayList<String>();
        Scanner scan = new Scanner(System.in);
        while(true){
            String x = scan.next();
            if(x == null || x.isEmpty()) break;
            System.out.println(x);

        }
    }
}

Take for example this bit of code. Try running it and entering words. The output should match exactly the words that you enter, which is what it should do. Next try entering a sentence and see what happens. When you are done change the code to be nextLine() instead and try it out. Now as to why the task specifically asks for words and not strings (as this is what it does test for), I can not answer that. What I do know is that in these tasks you should be using nextLine, or readLine if using a BufferedReader.

oli blaustrom

Level 18 , Luzern, Switzerland

17 December 2019, 19:04

displaying the index also gets the same last two points wrong