Someone please help. I am not getting why the "printing of the number of negative numbers in each set " is failing and again the zero test is also giving errors

Question about the task

Under discussion

package com.codegym.task.task04.task0429; /* Positive and negative numbers */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in)); String aa = bufferedReader.readLine(); int a = Integer.parseInt(aa); String bb = bufferedReader.readLine(); int b = Integer.parseInt(bb); String cc = bufferedReader.readLine(); int c = Integer.parseInt(cc); int count =0; int count1 = 0; if(a>0) count1 = count1 + 1; if(b>0) count1 = count1 + 1; if(c>0) count1 = count1 + 1; if(a==0) count1 = count1 + 0; if(b==0) count1 = count1 + 0; if(c==0) count1 = count1 + 0; if(a==0) count = count + 0; if(b==0) count = count + 0; if(c==0) count = count + 0; if(a<0) count = count + 1; if(b<0) count = count + 1; if(b<0) count = count + 1; System.out.println("Number of negative numbers: "+ count); System.out.println("Number of positive numbers: "+ count1); //write your code here } }

Use the keyboard to enter three integers. Display the number of positive numbers and the number of negative numbers in the original set, in the following form:
"Number of negative numbers: a" and "Number of positive numbers: b", where a and b are the unknowns.

Here are some examples:
a) if you enter the numbers
2
5
6
then we display
Number of negative numbers: 0 Number of positive numbers: 3

b) if you enter the numbers
-2
-5
6
then we display
Number of negative numbers: 2 Number of positive numbers: 1

Requirements:

The program should read the numbers from the keyboard.
The program should display text on the screen.
The program should display the number negative numbers in the original set.
The program should display the number of positive numbers in the original set.
If there are no negative numbers, the program should display "Number of negative numbers: 0".
If there are no positive numbers, the program should display "Number of positive numbers: 0".
Note that 0 is not a positive or negative number.

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

kochansky

Level 14 , Kielce, Poland

3 January 2020, 10:15

This code looks very bad. Learn something about loops. And about if/else if function. Instead of this :

if(a>0) count1 = count1 + 1;
        if(b>0) count1 = count1 + 1;
        if(c>0) count1 = count1 + 1;
        if(a==0) count1 = count1 + 0;
        if(b==0) count1 = count1 + 0;
        if(c==0) count1 = count1 + 0;

        if(a==0) count = count + 0;
        if(b==0) count = count + 0;
        if(c==0) count = count + 0;

        if(a<0) count = count + 1;
        if(b<0) count = count + 1;
        if(b<0) count = count + 1;

Use this :

int a = 0;
int b = 0;
for (int i = 0; i < 3; i++){
    int x = sc.nextInt();
    if (x> 0){
        b++;
    }
    else if (x < 0){
        a++;
    }
    else if(x == 0)
    {

    }