Problem with last test.

Question about the task

Sequential file output

Java Core, Level 6, Lesson 13

Under discussion

I have probilem with last test. I was trying almost everything but i dont know how to resolve this.

1. Figure out what the program does.
2. In a static block, read 2 filenames: firstFileName and secondFileName.
3. Inside the Solution class, create a public static ReadFileThread class that implements the ReadFileInterface interface (Think about what is more appropriate: Thread or Runnable).
3.1. The setFileName method must set the name of the file whose contents will be read.
3.2. The getFileContents method must return the contents of the file.
3.3. In the run method, read the contents of the file and close the stream. Separate the lines of the file with spaces.
4. Think about where you need to wait for the thread to finish to ensure that the files are displayed sequentially.
4.1. To do this, add a call to the appropriate method.

Expected output:
[entire contents of the first file] [entire contents of the second file]

Requirements:

The Solution class's static block should read from the console the names of two files and store them in the variables firstFileName and secondFileName.
In the Solution class, declare the public static ReadFileThread class.
The ReadFileThread class must implement the ReadFileInterface interface.
The ReadFileThread class must inherit the appropriate class.
The ReadFileThread class's run method should read lines from the file set by the setFileName method. And the getFileContents method of this same class must return the file contents. The return value is one string consisting of the lines of the file, separated by spaces.
The systemOutPrintln method must call the join method on the created object f.
The program's output should consist of 2 lines. Each line contains the contents of one file.

package com.codegym.task.task16.task1630; import java.io.*; import java.util.Scanner; public class Solution { public static String firstFileName; public static String secondFileName; static { { try { Scanner sc = new Scanner(System.in); firstFileName = sc.nextLine(); secondFileName = sc.nextLine(); } catch (Exception e) { } } } public static void main(String[] args) throws InterruptedException { systemOutPrintln(firstFileName); systemOutPrintln(secondFileName); } public static void systemOutPrintln(String fileName) throws InterruptedException { ReadFileInterface f = new ReadFileThread(); f.setFileName(fileName); f.start(); f.join(); System.out.println(f.getFileContents()); } public interface ReadFileInterface { void setFileName(String fullFileName); String getFileContents(); void join() throws InterruptedException; void start(); } public static class ReadFileThread extends Thread implements ReadFileInterface { String nameFile = ""; String content = ""; @Override public void setFileName(String fullFileName) { this.nameFile = fullFileName; } @Override public String getFileContents() { return content; } @Override public void start() { } @Override public void run() { String line = ""; try { FileReader fileReader = new FileReader(nameFile); BufferedReader bufferedReader = new BufferedReader(fileReader); while (bufferedReader.ready()) { line=bufferedReader.readLine(); content = content + line+" "; } } catch (IOException e) { e.printStackTrace(); } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Sela

Level 20 , Poland

5 August 2020, 06:08

lines 73 and 83 are redundant - remove them. line 81 should be:

this.content += bufferedReader.readLine() + " ";

Guadalupe Gagnon

Level 37 , Tampa, United States

24 January 2020, 15:10

There seems to be extra spaces added to the end of the output lines. These are characters that are not included in the file. I would try to either figure out a way to not add the last "space" character at the end, or use the .trim() method. Hint: To not add a space at the end, I use a method where I read the first line then I read the rest of the lines in a loop:

String contents = \*read first line*\
while(\*more lines exist*\)
   contents += " " + /*next read line*/

In that code no extra spaces occur.

Krystian C

Level 27 , San Francisco, United States

24 January 2020, 16:28

try { FileReader fileReader = new FileReader(nameFile); BufferedReader bufferedReader = new BufferedReader(fileReader); while (bufferedReader.ready()) { line=bufferedReader.readLine(); content = content + line+" "; } content= content.trim(); } catch (IOException e) { e.printStackTrace(); }

Krystian C

Level 27 , San Francisco, United States

24 January 2020, 16:30

I added trim() but last test is stil unpassed.