Any hints?

Question about the task

Under discussion

public class Solution { public static void main(String[] args) throws Exception { Scanner sc1 = new Scanner(System.in); ArrayList<String> list = new ArrayList<>(); for(int x = 0; x<10; x++) { String w = sc1.nextLine(); list.add(w); } int index = 0; int max = 0; int min = 0; for (String y : list) { if (y.length() > max) { max = y.length(); int x = list.indexOf(y); } for(String r : list) { if (r.length() < min) { min = r.length(); int p = list.indexOf(r); } } if (x<p) { System.out.println(max); } else { System.out.println(min); } } } }

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.Scanner; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { Scanner sc1 = new Scanner(System.in); ArrayList<String> list = new ArrayList<>(); for(int x = 0; x<10; x++) { String w = sc1.nextLine(); list.add(w); } int index = 0; int max = 0; int min = 0; for (String y : list) { if (y.length() > max) { max = y.length(); int x = list.indexOf(y); } for(String r : list) { if (r.length() < min) { min = r.length(); int p = list.indexOf(r); } } if (x<p) { System.out.println(max); } else { System.out.println(min); } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Sanjay Chauhan

Level 28 , Delhi, India

5 February 2020, 02:57

You can check my solution. Hope it helps. Thanks.

//STEP 1: Declare a string list variable and immediately initialize it.
        ArrayList<String> stringArrayList = new ArrayList<String>();
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int minPostionOfTheElement=0,maxPositonOfTheElement=0;

        //STEP 2: Add 10 strings from the keyboard
        for (int i=0;i<10;i++){
            stringArrayList.add(reader.readLine());
        }

        //STEP3: Find out minimun and max element position.
        for(int i=1;i<stringArrayList.size()-1;i++){
            if(stringArrayList.get(minPostionOfTheElement).length()> stringArrayList.get(i).length())
                minPostionOfTheElement=i;

            if(stringArrayList.get(maxPositonOfTheElement).length()<stringArrayList.get(i).length())
                maxPositonOfTheElement=i;
        }

        //STEP 4: Find out which string occurs earlier in the list: the shortest or the longest.  Display the string accordingly.
        if(minPostionOfTheElement < maxPositonOfTheElement)
            System.out.println(stringArrayList.get(minPostionOfTheElement));
        else
        if(maxPositonOfTheElement < minPostionOfTheElement)
            System.out.println(stringArrayList.get(maxPositonOfTheElement));
        else
            System.out.println(stringArrayList.get(maxPositonOfTheElement));

krystian

Level 9 , Kozle, Poland

1 February 2020, 08:17

Hi. What I wanted to do is : create an ArrayList with 5 Strings. Then, loop through the ArrayList and find the longest String. Check index of that String and save the index in a variable. Then loop through the ArrayList and find the shortest String and save the index in a variable. Finally if the index of the longest String is smaller than the index of the shortest it means that the longest String was earlier. Does it make sense ?

Guadalupe Gagnon

Level 37 , Tampa, United States

31 January 2020, 21:27

One big problem in this code is that you are not using indentation properly. This makes it very confusing to figure out what is going on. Just adding indentation helps:

for (String y : list) {
   if (y.length() > max) {
      max = y.length();
      int x = list.indexOf(y);
   }
   for(String r : list) {
      if (r.length() < min) {
         min = r.length();
         int p = list.indexOf(r);
      }
   }
   if (x<p) {
      System.out.println(max);
   } else {
      System.out.println(min);
   }
}

now you can see what code is in what block. Here are some problems: 1 - x and p (lines 30 and 36) are declared inside blocks of code, and then are being used outside of those blocks of code (line 40). This breaks the rules for regarding "variable scope". I would recommend reading about this 2 - the output lines (lines 40-44) are inside are inside the loop at line 27. Because of this, they will be reached every singe loop cycle and you will have 10 output lines. The code doesn't work in its current state. I would like to recommend a path to fixing what you have, but It is hard to tell what you are intending to do without any notes.