Any hints? I think it should work

Question about the task

Under discussion

public static ArrayList<String> fix(ArrayList<String> list) { for (int x = 0; x<list.size(); x++) { if (list.get(x).contains("r")){ if (list.get(x).contains("l")){ } else { list.remove(x); x--; } } else if (list.get(x).contains("l")){ if (list.get(x).contains("r")){ continue; } else { list.add(x); x++; } } } return list; } }

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("love"); // 1 list.add("lyre"); // 2 list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { for (int x = 0; x<list.size(); x++) { if (list.get(x).contains("r")){ if (list.get(x).contains("l")){ } else { list.remove(x); x--; } } else if (list.get(x).contains("l")){ if (list.get(x).contains("r")){ continue; } else { list.add(x); x++; } } } return list; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

4 February 2020, 19:53

Line 40 seems to be the main issue. The next problem is that when you add a new value to the list it gets added to the end, not in the middle. It is compounded by adding 1 more to x so that you skip the next value. Fix both of these issues and you should pass. Few Tips: #1 Instead of calling the List.contains() method a bunch of times, I find it easier to declare a variable and set it to that so you only call it one time. #2 you can also do this for boolean values, instead of checking them multiple times Example:

for (int x = 0; x<list.size(); x++) {
   String temp = list.get(x);

   // checks for r and l
   boolean conR = temp.contains("r"), conL = temp.contains("l");

   if (conR && !conL){
      // remove temp
   } else if (conL && !conR){
      // add temp
   }
}