Why wont my break statement work ?

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Under discussion

For some reason the for loop wont stop once the if condition is fulfilled. How do i resolve this?

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> strings = new ArrayList<String>(); for(int i=0; i<10; i++){ strings.add(br.readLine()); } int longest = 0; for(String string : strings){ if(string.length() >= longest){ longest=string.length(); } int shortest = Integer.MAX_VALUE; for(String string2 : strings){ if(string.length() <= shortest){ shortest=string2.length(); } } for(int i = 0; i<strings.size(); i++){ if(strings.get(i).length()==shortest || strings.get(i).length()==longest){ System.out.println(strings.get(i)); break; } } } }}

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Krystian C

Level 27 , San Francisco, United States

8 February 2020, 23:05

Check what was wrong. I added comments where was a problem.

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

        ArrayList<String> strings = new ArrayList<String>();
        for(int i=0; i<5; i++){
            strings.add(br.readLine());
        }

        int longest = 0;

        for(String string : strings) {
            if (string.length() >= longest) {
                longest = string.length();
            }
        }        //check here

            int shortest = Integer.MAX_VALUE;

            for(String string2 : strings){
                if(string2.length() <= shortest){  ///// check here
                    shortest=string2.length();
                }
            }


            for(int i = 0; i<strings.size(); i++){

                if(strings.get(i).length()==shortest || strings.get(i).length()==longest)
                {
                    System.out.println(strings.get(i));

                    break;

                }
            }
        }
    }

Luca Hofmann

Level 19 , Hamburg, Germany

12 February 2020, 21:10

Reached lvl 10 while leaving this unsolved, looking back at it, these were silly mistakes. Thanks.