Not passing the last requirement! I suspect the problem is in the FileStorageStrategy class

Question about the task

Under discussion

Not passing the last requirement! I suspect the problem is in the FileStorageStrategy class but I can't find how/why. Can someone give me a small hint?

We've tested our strategies many times using the Solution class's testStrategy() method. It's time to use JUnit to write real unit tests.
14.1. Read about unit tests.
14.2. Download and connect the JUnit 4.12 library. Figure out how to use it. The JUnit library depends on the hamcrest-core library. Connect it as well. Use version 1.3.
14.3. Add a FunctionalTest class to the tests package. In this class, we'll check the functionality of our strategies.
14.4. Add a testStorage(Shortener shortener) method to the FunctionalTest class. It must:
14.4.1. Create three strings. String 1 and 3 should be the same.
14.4.2. Get and save identifiers for all three strings using shortener.
14.4.3. Check that the identifier for String 2 is not equal to the identifier for Strings 1 and 3.

Hint: Assert.assertNotEquals method.

14.4.4. Check that the identifiers for Strings 1 and 3 are equal.

Hint: Assert.assertEquals method.

14.4.5. Use shortner to get three strings for three ids.
14.4.6. Check that the strings obtained in the preceding item are the same as the original.

Hint: Assert.assertEquals method.

14.5. Add tests to the FunctionalTest class:
14.5.1. testHashMapStorageStrategy()
14.5.2. testOurHashMapStorageStrategy()
14.5.3. testFileStorageStrategy()
14.5.4. testHashBiMapStorageStrategy()
14.5.5. testDualHashBidiMapStorageStrategy()
14.5.6. testOurHashBiMapStorageStrategy()
Each test must have a @Test annotation. Create the appropriate strategy. Create a Shortener object based on the strategy and call the corresponding testStorage method.
Run the program and verify that all tests pass.

Requirements:

The FunctionalTest class must be added to the created tests package.
In the testStorage method, the getId and getString methods must be called three times.
The test methods listed in the task conditions should be marked only with the @Test annotation.
Each test method must call the testStorage method.

package com.codegym.task.task33.task3310; import com.codegym.task.task33.task3310.strategy.*; import com.codegym.task.task33.task3310.tests.FunctionalTest; import java.util.Date; import java.util.HashSet; import java.util.Set; public class Solution { public static Set<Long> getIds(Shortener shortener, Set<String> strings){ Set<Long> set = new HashSet<>(); for (String s : strings){ set.add(shortener.getId(s)); } return set; } public static Set<String> getStrings(Shortener shortener, Set<Long> keys){ Set<String> set = new HashSet<>(); for (Long id : keys){ set.add(shortener.getString(id)); } return set; } public static void testStrategy(StorageStrategy strategy, long elementsNumber){ Helper.printMessage(strategy.getClass().getSimpleName()); Set<String> test = new HashSet<>(); for (int i=0;i<elementsNumber;i++){ test.add(Helper.generateRandomString()); } Shortener shortener = new Shortener(strategy); long startTime = new Date().getTime(); for (String s : test){ shortener.getId(s); } long endTime = new Date().getTime(); long timeElapsed = endTime - startTime; Helper.printMessage(timeElapsed+""); Set<Long> idTest = new HashSet<>(); for (String s : test){ idTest.add(shortener.getId(s)); } long startTime2 = new Date().getTime(); for (Long id : idTest){ shortener.getString(id); } long endTime2 = new Date().getTime(); long timeElapsed2 = endTime2 - startTime2; Helper.printMessage(timeElapsed2+""); Set<String> stringTest = new HashSet<>(); for (Long id : idTest){ stringTest.add(shortener.getString(id)); } if (stringTest.equals(test)) Helper.printMessage("The test passed."); else if (!stringTest.equals(test)) Helper.printMessage("The test failed."); } public static void main(String[] args) { //FunctionalTest functionalTest = new FunctionalTest(); //functionalTest.testHashMapStorageStrategy(); //functionalTest.testOurHashMapStorageStrategy(); //functionalTest.testFileStorageStrategy(); //functionalTest.testHashBiMapStorageStrategy(); //functionalTest.testOurHashBiMapStorageStrategy(); //functionalTest.testDualHashBidiMapStorageStrategy(); //testStrategy(new OurHashBiMapStorageStrategy(), 100); //testStrategy(new HashBiMapStorageStrategy(), 100); //testStrategy(new FileStorageStrategy(), 100); //testStrategy(new HashBiMapStorageStrategy(), 100); //testStrategy(new OurHashBiMapStorageStrategy(), 100); //testStrategy(new DualHashBidiMapStorageStrategy(), 100); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Michał

Level 41 , Krakow, Poland

26 March 2021, 19:17

I had the same problem. For everyone looking for the answer: I downloaded JUnit 4.13.2 (the latest version available at the time). The task tells us to download v. 4.12, though. So I did and it worked. Didn't change the code so it must be that.

June Sung Park

Level 41 , Yangp'yong, Korea, Republic of

27 July 2020, 22:58

I looked at your getKey() method in FileStorageStrategy class which is called by getId method in Shortener class which in turn is called by testStorage method in FunctionalTest class. Your getKey() method does not traverse all the entries linked to the entry stored in the FileBucket. Here is what I did for getKey() method: public Long getKey(String value) { try { if (value == null) return null; for (FileBucket f : table) { if (f == null) continue; Entry e = f.getEntry(); while (e != null) { if (e.getValue().equals(value)) return e.getKey(); e = e.next; } } return null; } catch (Exception e) { return null; } } You may need to change other methods in FileStorageStrategy and the other five storage strategies. Wherever you search all entries in the table, you need to visit each bucket to get the entry in it, and then follow the "entry.next" to get all other entries linked to that first entry. I had to do this to pass Part 14.

yz Backend Developer

17 April 2020, 23:24

did u find out?

Seb

Level 41 , Crefeld, Germany

24 February 2020, 19:49

Not sure whether that's the issue, but on line 43 you're calling testStorage(shortener), whereas in all other cases you are calling this.testStorage(shortener)...