Requirements 2 and 5 failing

Question about the task

Under discussion

Hey All, A little help if you don't mind. I feel I've met all the requirements but its says requirement 2 and 5 are wrong? Any help would be much appreciated. Thanks in advance.

1. Read a file name from the console.
2. Read lines from the console until the user enters the "exit".
3. Write all the entered lines to the file, each on a new line.

Requirements:

The program must read the file name from the console.
Create and use a BufferedWriter object.
The program should not read anything from the file system.
The program must read lines from the console until the user enters "exit".
The program must write absolutely all of the entered lines (including "exit") to the file, each on a new line.
The main method should close the BufferedWriter object after using it.

package com.codegym.task.task13.task1319; import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.FileWriter; import java.io.InputStreamReader; import java.io.FileInputStream; import java.io.File; /* Writing to a file from the console */ public class Solution { public static void main(String[] args) { // write your code here FileInputStream readIn = null; BufferedReader reader = null; BufferedWriter writer = null; File file = new File("C:/development/OutputEntered.txt"); try { reader = new BufferedReader(new InputStreamReader(System.in)); String text = null; //readIn = new FileInputStream(text); do { //int data = readIn.read(); text = reader.readLine(); FileWriter fw = new FileWriter(file, true); writer = new BufferedWriter(fw); writer.write(text); writer.newLine(); writer.flush(); } while(!(text.equalsIgnoreCase("exit"))); writer.close(); }catch (Exception e){ System.out.println(e); e.printStackTrace(); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

hanumohan

Level 25 , San Jose, United States

27 April 2020, 00:35

BufferedReader br = new BufferedReader(new InputStreamReader(System.in));
      BufferedWriter bw = new BufferedWriter(new FileWriter(br.readLine()));
      while(true){
          String s = br.readLine();
          if(s.equals("exit")){
              bw.write(s);
              bw.close();
              break;
          }
          else
              bw.write(s);
          bw.newLine();

      }

Guadalupe Gagnon

Level 37 , Tampa, United States

24 February 2020, 15:16

On these tasks it is important to follow the directions as close as possible. While this code does do what the task asks, there is a lot going on in in it that is above and beyond. I believe you were using a static file for tests purposes, so I will skip that part (read file name from console). The main problem I see with this code that is most likely causing a fail in validation is the FileWriter being initialized with append being "true". Having it inside a loop is opening a lot of unnecessary streams as well. All you need to do is initialize that when you read the file name and then put it in the BufferedWriter, all prior to the loop. Some tips: Streams are very resource intensive, you should declare and initialize them when you are ready to use them, as well as close them as soon as you are done with them. You should only use the append when you are adding things onto an existing file. In this task you are creating the file so there is no need to "append".

Derek

Level 14 , An Longfort, Ireland

24 February 2020, 16:00

Oh alright thanks a mill for that in depth explanation gave bit to think about! Very silly question but where do see I'm using the append. Also I've reworked it from some what you've said, again works as described but the same condition is still failing? public class Solution { public static void main(String[] args) { // write your code here try { File file = new File("C:/development/JavaStuff/Output.txt"); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); BufferedWriter writer = new BufferedWriter(new FileWriter(file)); String line; boolean running = true; while (running) { if((line = reader.readLine()).equalsIgnoreCase("exit")) { writer.write(line); writer.newLine(); writer.flush(); running = false; } else { writer.write(line); writer.newLine(); writer.flush(); } } reader.close(); writer.close(); }catch(Exception e){ System.out.println(e); e.printStackTrace(); } }