not verifying :(

Question about the task

Under discussion

package com.codegym.task.task10.task1019; import java.io.*; import java.util.HashMap; import java.util.Map; /* Functionality is not enough! */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); HashMap<String, Integer> hm = new HashMap<>(); int id ; String name; int flag = 0; try{ for(int i = 0; flag != 1 ; i++) { id = Integer.parseInt(reader.readLine()); name = reader.readLine(); if(name.isEmpty()) flag = 1; if(flag == 1) { System.out.println("Id=" + id); hm.put(name, id); } else { System.out.println("Id=" + id + " Name=" + name); hm.put(name, id); } }} catch(Exception e) { } for(Map.Entry<String, Integer> s : hm.entrySet()) { System.out.println(s.getKey() + " " + s.getValue()); } } }

Task: The program reads a pair (a number and string) from the keyboard and displays it on the screen.
New task: The program reads pairs (a number and string) from the keyboard and stores them in a HashMap.
Any empty input signifies the end of data entry.
The numbers can be repeated.
The strings are always unique.
The entered data must not be lost!
The program then displays the contents of the HashMap on the screen.
Each pair on a new line.

Example input:
1 Sam 2 I 1 Am

Example output:
1 Sam 2 I 1 Am

Requirements:

The program must read data from the keyboard.
The program should display text on the screen.
In the main method, declare a HashMap variable and immediately initialize it.
The program should put the pairs read from the keyboard into the HashMap.
The program should display the contents of the HashMap in accordance with the conditions. The key and value are separated by a space. Each value should be on a new line.

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Ryan

Level 16 , Ashburn, United States

29 June 2020, 18:06

- You are printing everything twice, your final for loop is all you need. - The final print is not in the correct order, pay attention to what is stored as a Key and what is a value. While complicated, the rest of the code seems to work so you should pass testing addressing the two points above.

VIVEK BARUAH

Level 20 , Eluru, India

12 June 2019, 06:25

You are making it too complicated brother. write code step by step. remember flow diagrams? while(true){ //continue the loop String data = reader.readLine(); // read the number first if(data.isEmpty()) break; // break if empty String data1 = reader.readLine(); ///read the string if(data1.isEmpty()){ // check if empty map.put("",Integer.parseInt(data)); // store the number mandatory with empty string break; // but we still have to break it } map.put(data1,Integer.parseInt(data)); // generic put statement for normal inputs }

Learner

Level 16 , India

10 October 2018, 11:12

Output of your code is: Id=1 Name=Sam Id=2 Name=I Id=1 Name=Am I 2 Am 1 Sam 1 The output expected as per task should be 1 Sam 2 I 1 Am

Sindhura

Level 15 , Delhi, India

10 October 2018, 12:38

But I am giving as System.out.println(s.getKey() + " " + s.getValue()); How can it print like this?

Ankush Rajput

Level 25 , Bhopal, India

10 October 2018, 13:27

Read every line of your code carefully.

hm.put(name, id);

You are putting name in place of key and id in place of value. Hence its is displaying name first and id second. You have to reverse that. Or you can change position of getKey and getValue in println().

Serg

Level 17 , Minsk, Belarus

20 June 2019, 16:18

- HashMaps store the values not in the input order, so it may has different output order; - to pass the validation the output code needs not to be the same as in example; - for example my output code is: 2 I 1 Am 1 Sam and it passed the validation; as for the task - Ankush Rajput commented.