The program seems to work completely fine, y - java help on CodeGym

package com.codegym.task.task04.task0419; /* Maximum of four numbers */ import java.io.*; import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { //write your code here Scanner sc = new Scanner(System.in); int a = sc.nextInt(); int b = sc.nextInt(); int c = sc.nextInt(); int d = sc.nextInt(); sc.close(); //when a is greatest if (a > b){ if (a > c){ if (a > d) System.out.println(a); else if (d > a) System.out.println(d); else if (a == d) System.out.println(a); } else if (a > d){ if (a == c) System.out.println(a); } else if (a == c && a == d) System.out.println(a); } //when b is greatest else if (b > c){ if (b > d){ if (b > a) System.out.println(b); else if (a > b) System.out.println(a); else if (b == a) System.out.println(b); } else if (b > a){ if (b == d) System.out.println(b); } else if (b == d && b == a) System.out.println(b); } //when c is greatest else if (c > d){ if (c > a){ if (c > b) System.out.println(c); else if (b > c) System.out.println(b); else if (c == b) System.out.println(c); } else if (c > b){ if (c == a) System.out.println(c); } else if (c == a && c == b) System.out.println(c); } //when d is greatest else if (d > a){ if (d > b){ if (d > c) System.out.println(d); else if (c > d) System.out.println(c); else if (d == c) System.out.println(d); } else if (d > c){ if (d == b) System.out.println(d); } else if (d == b && d == c) System.out.println(d); } //if all numbers are same else if (a == b && a == c){ if (a == d) System.out.println(a); } } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Pawel

Level 22 , Austin, TX, USA

10 March 2020, 16:21

3 lines version:

int ab= a>b?a:b;  //assign to ab greater value (a or b)
int cd= c>d?c:d; // assign to cd greater value (c or d)
System.out.println(ab<cd?cd:ab); // display geater (cd or ab)

Dorian

Level 7 , Mumbai, India

28 April 2020, 09:57

Thanks, but I don't quite know how to use these symbols yet. Will surely look back at this once I've gone through this section.

Misiu

Level 41 , Gdansk, Poland

9 March 2020, 01:53

Oh mine, how long is your code. //when a is greatest One line is enough. "&&" and suitable operator to compare numbers, And so on for other numbers.

28 April 2020, 09:56

Thankyou. I've made it shorter now. This worked for me. public static void main(String[] args) throws Exception { //write your code here Scanner sc = new Scanner(System.in); int a = sc.nextInt(); int b = sc.nextInt(); int c = sc.nextInt(); int d = sc.nextInt(); sc.close(); if (a >= b && a >= c){ if (a >= d) System.out.println(a); else System.out.println(d); } else if (b >= c && b >= d){ if (b >= a) System.out.println(b); else System.out.println(a); } else if (c >= d && c >= a){ if (c >= b) System.out.println(c); else System.out.println(b); } else if (d >= a && d >= b){ if (d >= c) System.out.println(d); else System.out.println(c); } }

28 April 2020, 10:40

Better :) I have sthg like this: if (a>=b && a>=c && a>=d) System.out.println(a);

Ashish RajAnand

Level 13 , Bhilai , India

9 March 2020, 01:45

line 22 if(a>c) -false it means c is greater line 30 no need to check again in else if (a>c) you should check c>d is true -c is greater false d is greater think hard and work smart i suggest you to understand every code

The program seems to work completely fine, yet it keeps showing that the conditions aren't satisfied... Kindly check what could be wrong in this code