CodeGym/Help with Java Tasks/Hi, what is wrong with the createRandomGamePiece method?

Level 41

16.03.2020
901views
10comments

Hi, what is wrong with the createRandomGamePiece method?

Question about the task

Under discussion

Hi, Despite the fact I had to manually write the whole GamePieceFactory method (where the task said at level 12 that it will complete it by its own), I don't know why it does not validate now. Can you help? Thanks

Implement the step() method in the Tetris class.
This method should drop the game piece down by one step.

If the game piece cannot be placed in the new location, then:
a) put it back (bring it back up)
b) land it (the game piece "lands")
c) delete all full lines in the field object
d) create a new game piece to replace the previous one.

Requirements:

You need to drop the current game piece down one step in the Tetris class's step() method.
In the Tetris class's step() method, you need to call the up method on the current game piece if it cannot be dropped below its current position.
In the Tetris class's step() method, you need to call the land method on the current game piece if it cannot be dropped below its current position.
In the Tetris class's step() method, you need to delete all full lines if the current game piece cannot be dropped below its current position.
In the Tetris class's step() method, if the current game piece cannot be dropped below its current position, you need to create a new random game piece (createRandomGamePiece method) and save it in the gamePiece field.

package com.codegym.task.task22.task2213; public class Tetris { private Field field; private GamePiece gamePiece; public static Tetris game; public Field getField() { return field; } public GamePiece getGamePiece() { return gamePiece; } public void run() { } public void step() { gamePiece.down(); if(!gamePiece.isCurrentPositionAvailable()) { gamePiece.up(); gamePiece.land(); field.removeFullLines(); gamePiece = GamePieceFactory.createRandomGamePiece(field.getWidth() / 2, 0); } } public static void main(String[] args) { game = new Tetris(); game.run(); } }

Comments (10)

Popular
New
Old

You must be signed in to leave a comment

Norbert Backend Developer

11 December 2020, 16:59

You have to only create new gamePiece outside the if

JianQiu Hwang

Level 35 , Washington

17 March 2020, 12:32

I passed the task with step() function as same as yours. However, the Tetris class is different. So you can copy the step() function, reset the task and then paste step() to get right.

Aleksander

Level 41 , England

17 March 2020, 12:38

Thanks, but I don't understand how it can help, I would be still at same point :D (And I've already checked restarting the task, nothing changed.)

JianQiu Hwang

Level 35 , Washington

17 March 2020, 12:43

This is my answer and same as yours.

public void step() {
    // Drop the game piece lower
    gamePiece.down();

    // If the game piece can't be placed in the current location
    if (!gamePiece.isCurrentPositionAvailable()) {
        gamePiece.up();                    // Put it back
        gamePiece.land();                // Land it

        field.removeFullLines();        // Remove the completed lines

        gamePiece = GamePieceFactory.createRandomGamePiece(field.getWidth()/2, 0); // Create a new game piece
    }
}

Aleksander

Level 41 , England

17 March 2020, 12:51

You want me to reset the task, get to the same level and paste the step method in order to pass? I tried it many times. The problem is the GamePieceFactory class (The last condition).

JianQiu Hwang

Level 35 , Washington

17 March 2020, 12:57

And your GamePieceFactory.class has no difference with mine.

Aleksander

Level 41 , England

17 March 2020, 13:26

Can you paste please, maybe there is a little mistake I can't see..

JianQiu Hwang

Level 35 , Washington

17 March 2020, 13:59

This is run in Tetris.class

public void run() throws Exception {
        // Create a KeyboardObserver object and start it.
        KeyboardObserver keyboardObserver = new KeyboardObserver();
        keyboardObserver.start();

        // Set the initial value of isGameOver to false
        isGameOver = false;
        // Create the first game piece in the middle at the top: x = half of the width, y = 0.
        gamePiece = GamePieceFactory.createRandomGamePiece(field.getWidth() / 2, 0);

        // The game is not over yet
        while (!isGameOver) {
            // Does the observer have any key events?
            if (keyboardObserver.hasKeyEvents()) {
                // Get the first event from the queue
                KeyEvent event = keyboardObserver.getEventFromTop();
                // If 'q', then exit the game.
                if (event.getKeyChar() == 'q') return;
                // If "left arrow", then move the game piece to the left
                if (event.getKeyCode() == KeyEvent.VK_LEFT)
                    gamePiece.left();
                    // If "right arrow", then move the game piece to the right
                else if (event.getKeyCode() == KeyEvent.VK_RIGHT)
                    gamePiece.right();
                    // If the key code is 12 ("5 on the numeric keypad), rotate the game piece
                else if (event.getKeyCode() == 12)
                    gamePiece.rotate();
                    // If it's a space, then drop the game piece at top speed
                else if (event.getKeyCode() == KeyEvent.VK_SPACE)
                    gamePiece.downMaximum();
            }

            step();             // Take a step
            field.print();      // Display the field
            Thread.sleep(300);  // Pause for 300 milliseconds (about 1/3 of a second)
        }

        // Display "Game Over"
        System.out.println("Game Over");
    }

JianQiu Hwang

Level 35 , Washington

17 March 2020, 14:00

This is GamePieceFactory.class

package com.codegym.task.task22.task2213;

/**
 * The GamePieceFactory class is responsible for creating GamePiece objects.
 */
public class GamePieceFactory {
    /**
     * A set of six patterns for creating game pieces.
     */
    public static final int[][][] BRICKS = {{
            {1, 1, 0},                          //   X X
            {0, 1, 1},                          //     X X
            {0, 0, 0}}, {                       //

            {1, 0, 0},                          //   X
            {1, 1, 0},                          //   X X
            {0, 1, 0}}, {                       //     X

            {0, 1, 0},                          //   X
            {0, 1, 0},                          //   X
            {0, 1, 0}}, {                       //   X

            {1, 1, 0},                          //   X X
            {1, 1, 0},                          //   X X
            {0, 0, 0}}, {                       //

            {1, 1, 1},                          //   X X X
            {0, 1, 0},                          //     X
            {0, 0, 0}}, {                       //

            {1, 1, 1},                          //   X X X
            {1, 1, 1},                          //   X X X
            {0, 0, 0}}                          //
    };

    /**
     * The method selects a random pattern and uses it to create a new game piece.
     */
    public static GamePiece createRandomGamePiece(int x, int y) {
        int index = (int) (Math.random() * 6);
        return new GamePiece(x, y, BRICKS[index]);
    }
}

Aleksander

Level 41 , England

17 March 2020, 14:07

Thanks, I need to rewrite the run method and the whole KeyboardObserver class which, for some reason wasn't even created...