Help "checkBoxCollisionAndMoveIfAvailable"

Question about the task

Resolved

Hi, Does anyone know what could be a problem with second validation: Implement the boolean checkBoxCollisionAndMoveIfAvailable(Direction direction) method in the Model class.

The time has come to implement the model's move() method, which is responsible for movement. But first, let's implement some helper methods. Add the following methods to the Model class:
15.1. boolean checkWallCollision(CollisionObject gameObject, Direction direction). This method checks for collisions with a wall. It should return true if the gameObject will collide with a wall by moving in the passed direction; otherwise, it should return false. To determine if there is a collision, use the game object's isCollision() method.
15.2. boolean checkBoxCollisionAndMoveIfAvaliable(Direction direction). This method checks for collisions with boxes. The method should:
15.2.1. Return true if the player can't move in the specified direction (i.e. the cell is occupied by a box with a wall behind it or by a box with another box behind it).
15.2.2. Return false if the player can move in the specified direction (i.e. the cell is occupied by an empty cell or by a storage location or by a box with an empty cell or a storage location behind it). In this case, if a movable box is in the way, then you need to move it to new coordinates. Note that all the objects move by a fixed distance equal to BOARD_CELL_SIZE regardless of the dimensions used for drawing.

Hint: check for collisions using the game objects' isCollision() methods and the model's checkWallCollision() method.

15.3. void checkCompletion(). This method must check whether the level has been completed (whether all the storage locations have boxes on them, i.e. their coordinates match). If this condition is true, then let the event listener know that the current level is complete.
15.4. void move(Direction direction). The method should:
15.4.1. Check for a wall collision (use the checkWallCollision() method). If there is a collision, then exit the method.
15.4.2. Check for a box collision (use the checkBoxCollisionAndMoveIfAvaliable() method). If there is a collision, then exit the method.
15.4.3. Move the player in the passed direction.
15.4.4. Check whether the level is completed.

Run the program and be sure that the player can move itself and boxes, that walls prevent the player from moving, and that when you move all the boxes onto storage locations that a message about completing the level is displayed.

Requirements:

Implement the boolean checkWallCollision(CollisionObject gameObject, Direction direction) method in the Model class.
Implement the boolean checkBoxCollisionAndMoveIfAvailable(Direction direction) method in the Model class.
Implement the void checkCompletion() method in the Model class.
Implement the void move(Direction direction) method in the Model class.

package com.codegym.task.task34.task3410.controller; import com.codegym.task.task34.task3410.model.Direction; import com.codegym.task.task34.task3410.model.GameObjects; import com.codegym.task.task34.task3410.model.Model; import com.codegym.task.task34.task3410.view.View; public class Controller implements EventListener { private View view; private Model model; public Controller() { view = new View(this); model = new Model(); view.init(); view.setEventListener(this); model.restart(); model.setEventListener(this); } public static void main(String[] args) { Controller controller = new Controller(); } public GameObjects getGameObjects() { return this.model.getGameObjects(); } @Override public void move(Direction direction) { this.model.move(direction); this.view.update(); } @Override public void restart() { this.model.restart(); this.view.update(); } @Override public void startNextLevel() { this.model.startNextLevel(); this.view.update(); } @Override public void levelCompleted(int level) { this.view.completed(level); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Łukasz

Level 41 , Lodz, Poland

18 March 2020, 06:13

Strange it looks like issue in different method "checkWallCollision", now passed.

Aleksander

Level 41 , England

24 April 2020, 14:30

Hej, co poprawiłeś że przeszło?

Łukasz

Level 41 , Lodz, Poland

25 April 2020, 06:41

Nie pamietam, implementacja funkcji: public boolean checkWallCollision(CollisionObject gameObject, Direction direction) { for (Wall wall : gameObjects.getWalls()) if (gameObject.isCollision(wall, direction)) return true; return false; } public boolean checkBoxCollisionAndMoveIfAvailable(Direction direction) { for (Box box : gameObjects.getBoxes()) { if (gameObjects.getPlayer().isCollision(box, direction)) { if (checkWallCollision(box, direction)) return true; for (Box otherBox : gameObjects.getBoxes()) { if (box.isCollision(otherBox, direction)) return true; } switch (direction) { case LEFT: box.move(-BOARD_CELL_SIZE, 0); break; case RIGHT: box.move(BOARD_CELL_SIZE, 0); break; case UP: box.move(0, -BOARD_CELL_SIZE); break; case DOWN: box.move(0, BOARD_CELL_SIZE); } } } return false; }

Łukasz

Level 41 , Lodz, Poland

18 March 2020, 06:10

It did not help, with removing 75 and 77 the same result. After with "checkBoxCollisionAndMoveIfAvaliable" the two validators are failing.

Elvis Lee

Level 41 , Aurora, United States

17 March 2020, 23:20

Also, the name of the method should be "checkBoxCollisionAndMoveIfAvaliable", the instruction has a typo "Avaliable", but we need to follow to pass the validator.

Elvis Lee

Level 41 , Aurora, United States

17 March 2020, 20:45

Try to remove line 75 and 77 break statements