Everything works but 4 requirements failed

Question about the task

Building a file

Java Core, Level 8, Lesson 11

Resolved

Hello, My code works but the requirements fail no matter what i do. Could someone help me?

Let's build a file from various pieces.
Read file names from the console.
Each file has a name: <someName>.partN.

For example, Lion.avi.part1, Lion.avi.part2, ..., Lion.avi.part37.

The file names are supplied in random order. The word "end" is used to stop reading in file names.
In the folder where all the files are located, create a file without the "part" suffix, i.e. without ".<partN>".

For example, Lion.avi.

Use a buffer to copy all the bytes from the partial files to the created file.
Copy the first in the proper order, first the first part, then the second, ..., finally - the last part.
Close the streams.

Requirements:

The program must read file names from the console until the word "end" is entered.
Create a stream to write to the file without the "part" suffix (".<partN>") in the folder with all the "part" files.
Copy all the bytes from the *.partN files to the new file.
You should use a buffer for the reading and writing.
The file streams must be closed.
Don't use static variables.

package com.codegym.task.task18.task1825; import java.io.*; import java.util.*; /* Building a file */ public class Solution { public static void main(String[] args) throws IOException { TreeMap<Integer, String> files = GetList(); allToOne(files); } // Read strings and return a map public static TreeMap<Integer, String> GetList() throws IOException { TreeMap<Integer, String> files = new TreeMap<>(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); while (true){ String readLine = reader.readLine(); if (readLine.equalsIgnoreCase("end")) break; File file = new File(readLine); String part = file.getName().split("\\.")[2]; files.put(Integer.parseInt(part.split("part")[1]),readLine); } reader.close(); return files; } // Copy all files to one public static void allToOne(TreeMap<Integer, String> files) throws IOException { File file = new File(files.get(1)); String[] name = file.getName().split("\\."); String path = file.getParent().split("part")[0] + "\\" + name[0]+"."+ name[1]; BufferedWriter bw = new BufferedWriter(new FileWriter(path,true)); for (Map.Entry<Integer,String> pair: files.entrySet()) { BufferedReader bfr = new BufferedReader(new InputStreamReader(new FileInputStream(pair.getValue()))); if (pair.getKey() != 1) bw.newLine(); while (bfr.ready()) bw.write(bfr.read()); bfr.close(); } bw.close(); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Wei Cui

Level 39 , Newark, United States

28 March 2020, 20:51

solution

public static void main(String[] args) throws IOException {
        //add file name to list
        ArrayList<String> fileList = new ArrayList<>();
        BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in));
        String line;
        while(!(line = bufferedReader.readLine()).equals("end"))
            fileList.add(line);
        //create new file
        String newFileName = fileList.get(0).substring(0, fileList.get(0).lastIndexOf("."));
        //sort file order
        Collections.sort(fileList);


        //read each file content then write into new file
        BufferedWriter bw = new BufferedWriter(new FileWriter(newFileName));
        for (String fName : fileList) {
            BufferedReader br = new BufferedReader(new FileReader(fName));
            while(br.ready())
                bw.write(br.read());

            br.close();
        }

       bw.close();

    }

Seth

Level 38 , Warsaw, Poland

29 March 2020, 10:50

Thanks, It seams I over complicated the task. This is much clearer. Also thanks for .substring, didn't know such things existed.

Wei Cui

Level 39 , Newark, United States

29 March 2020, 16:07

Just keep learning and do the practice, you also could find easier and clear way to solve issue