I passed but rewrote my code. Where is the issue in my first code?

Question about the task

Reading and writing to a file: CodeGym

Java Core, Level 10, Lesson 2

Under discussion

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

syan

Level 20 , United States

14 August 2020, 18:04

public void save(OutputStream outputStream) throws Exception { PrintWriter pw = new PrintWriter(outputStream); for (User user : users) { pw.write(user.getFirstName() + "," + user.getLastName() + "," + user.getBirthDate()+ "," + user.isMale() + "," + user.getCountry().getDisplayName() + "\n"); } pw.flush(); } public void load(InputStream inputStream) throws Exception { BufferedReader br = new BufferedReader(new InputStreamReader(inputStream)); String str; String[] temp; while ((str = br.readLine()) != null) { temp = str.split(","); User user = new User(); user.setFirstName(temp[0]); user.setLastName(temp[1]); user.setBirthDate(new Date(temp[2])); switch (temp[3]) { case "true": user.setMale(true); break; case "false": user.setMale(false); break; } switch (temp[4]) { case "United States": user.setCountry(User.Country.UNITED_STATES); break; case "United Kingdom": user.setCountry(User.Country.UNITED_KINGDOM); break; case "Other": user.setCountry(User.Country.OTHER); break; } users.add(user); } }

Nouser

Level 36 , Germany

4 May 2020, 12:46

I like the solution, guess I rewrite mine so it is working like yours. I saved the list size as first line into the file. Problems I've seen in your solution that may stop it from working 1. infinite loop in the save method - while (!(users.isEmpty())){ 2. it's far easier to save the birth date as long 3. in the load method... there are no users in the list, so it'll never load while (!(users.isEmpty())){ Just a hint, if you want to get rid of all the comparisons..

boolean isMale = Boolean.parseBoolean(reader.readLine());
User.Country country = User.Country.valueOf(reader.readLine());

Nouser

Level 36 , Germany

4 May 2020, 12:58

OK, have changed my methods, too, thanks ;)

public void save(OutputStream outputStream) throws Exception {
    PrintWriter writer = new PrintWriter(outputStream);
    if (!users.isEmpty()) {
        for (User u : users) {
            writer.println(u.getFirstName());
            writer.println(u.getLastName());
            writer.println(u.getBirthDate().getTime());
            writer.println(u.isMale());
            writer.println(u.getCountry());
        }
    }
    writer.flush();
}

public void load(InputStream inputStream) throws Exception {
    BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
    while (reader.ready()) {
            //I've added a constructor (firstName, lastName, birthDate, isMale, coutry)
            users.add( new User(reader.readLine(), /* firstName*/
                                reader.readLine(), /* lastName */
                                new Date(Long.parseLong(reader.readLine())), /* birthDate */
                                Boolean.parseBoolean(reader.readLine()), /* isMale */
                                User.Country.valueOf(reader.readLine()) /* country */
                                ));
    }
}