Not meeting condition 5

Question about the task

Under discussion

So I am trying to solve this task and it says on condition 5 to make sure it works correctly for negative numbers, but under my logic it should not give any issues. What's wrong then??

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int maximum = 0; int numb2 = 0; String sNumb1 = reader.readLine(); int numb1 = Integer.parseInt(sNumb1); if(numb1 > 0){ for(int i = 0; i < numb1; i++){ String sNumb2 = reader.readLine(); if(Integer.parseInt(sNumb2) > maximum){ maximum = Integer.parseInt(sNumb2); } } System.out.println(maximum); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

WIDMO

Level 25 , Gdańsk, Poland

Expert

24 April 2020, 19:46

The answer id quite simple. If u test with this input: 3 -1 -2 -3 U will get the output: 0 The give a clue what's wrong. Look at your code from 13 line:

int maximum = 0;

Writing that you are declaring that you will use integer variable "maximum" and ... it has a value of 0 for start. Now check the previous situation when all of you input number are negative and ... yes, you've guessed, with all negative numbers the maximum is 0 because in if-statement in 20 line in you code is fixed. You can fix that or check code of mine:

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int maksimum;
        int n = Integer.parseInt(reader.readLine());
        if (n>0) {
            maksimum = Integer.parseInt(reader.readLine());
            for(int i=1;i<n;i++) {
                int liczba = Integer.parseInt(reader.readLine());
                maksimum = liczba > maksimum ? liczba : maksimum;
            }
            System.out.println(maksimum);
        }
    }
}

Gellert Varga

Level 23 , Szekesfehervar, Hungary

24 April 2020, 20:29

I think the first half of your answer is very good, but it is not lucky to hand over a complete program or complete solution...

WIDMO

Level 25 , Gdańsk, Poland

Expert

24 April 2020, 20:52

I'll remember that :)