:/ why is it not working?

Question about the task

Archived

I have tried doing it like the last problem. I can't figure out how to pass the conditions

1. Create a list of strings.
2. Read 5 strings from the keyboard and add them to the list.
3. Using a loop, find the shortest string in the list.
4. Display the string.
5. If there is more than one, display each on a new line.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 5 strings from the keyboard and write them to the list.
The program should display the shortest string.
If several strings are the shortest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0709; import java.util.Scanner; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { int i; List<String>strings = new ArrayList<String>(); Scanner sc = new Scanner(System.in); for (int i = 0; i<5;i++) { String s = sc.nextLine(); strings.add(s); } public static void main(String[] args) { //write your code here for (int i = 0; i<5; i++) { if (strings.get(i).length() == shortestString().length()) System.out.println(strings.get(i)); } } public static String shortestString() { String min = strings.get(0); for(int j = 1; j<5; j++) { if (strings.get(j).length()<strings.get(0).length()) min = strings.get(j); } return min; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Prassha

Level 24 , Chagford, United Kingdom

31 May 2020, 14:37

i have tested bellow code with strings /* // i have tested the code with these strings strings.add("vvvv"); strings.add("fwfw"); strings.add("gfegegeg"); strings.add("dqdqdqd"); strings.add("fwfwfw"); */ it worked and I put little bit of explanation with whats wrong with above code

Prassha

Level 24 , Chagford, United Kingdom

31 May 2020, 14:35

import java.util.ArrayList; import java.util.List; import java.util.Scanner; public class Main { public static void main(String[] args) { //write your code here //moving this bit of your code inside the static {} List<String> strings = new ArrayList<String>(); ///* Scanner sc = new Scanner(System.in); for(int i = 0; i<5;i++) { String s = sc.nextLine(); strings.add(s); } ///* //check the shortest string from the array using the shortestString method List<String> sub = shortestString((ArrayList<String>) strings); for (int i = 0; i<sub.size(); i++) { System.out.println(sub.get(i)); } } public static ArrayList shortestString(ArrayList<String> list) { //adding array list to the parameter, // without the parameter which string list are you going to compare? //returning an array list of strings in case more one shortest string with same length //find the shortest string from the list String min = list.get(0); //assigning anything from the list to min for(int j = 1; j<list.size(); j++) { if (list.get(j).length()<min.length()) //check if the string from the list is smaller than min min = list.get(j); //if so assign to min } //now min is the shortest string but if there more than one same length string with a shortest //check if there is another string with same length as shortest or min string. ArrayList<String> subList = new ArrayList<>(); for(int i =0;i<list.size();i++) { if(list.get(i).length()==min.length()) subList.add(list.get(i)); } return subList;// return list with shortest strings } }

Thomas

Level 32 , Bayreuth, Germany

10 May 2020, 18:34

you've written code, where it is not valid. Starting from line 17. Probably you meant to write this in the main method.