Last condition is not passing could anyone help me please

Question about the task

Calculating salaries

Java Core, Level 9, Lesson 11

Under discussion

The first parameter of the main method is a file name.
Each line of the specified file has the following format:
name value
where [name] is a String and [value] is a double. [name] and [value] are separated by a space.

Find the sum of all the values for each name.
Display all the data, sorted by name in ascending order.
Close the streams.

Example input file:
Peterson 2 Smith 6 Baxter 1.35 Peterson 3.1

Example output:
Baxter 1.35 Peterson 5.1 Smith 6.0

Requirements:

The program must NOT read data from the console.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write to the console each name, sorted in ascending order, and the sum of all its values.

package com.codegym.task.task19.task1919; import java.util.*; import java.io.*; import java.text.ParseException; /* Calculating salaries */ public class Solution { public static void main(String[] args) throws IOException,ParseException { FileReader bf = new FileReader(args[0]); List<Employee> employeeList = new LinkedList<Employee>(); Scanner sc = new Scanner(bf); bf.close(); while(sc.hasNext()) { boolean isExist = false; String readLine = sc.nextLine(); String[] employeeInfo = readLine.split(" "); String empName = employeeInfo[0]; double salary = Double.parseDouble(employeeInfo[1]); for (Employee em : employeeList) { if (em.getName().equals(empName)) { em.setSalary(em.getSalary() + Double.parseDouble(employeeInfo[1])); isExist = true; } } if(!isExist) { employeeList.add(new Employee(empName, salary)); } } Collections.sort(employeeList); double sum = 0.0; for(Employee e: employeeList) { System.out.println(e.toString()+"\n"); sum+=e.getSalary(); } System.out.println(sum); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Teodor Clipa Backend Developer

27 May 2020, 15:28

1. You're closing the FileReader before parsing the file: move bf.close at the end of your main method; 2. You have one extra newline after every outputted line: remove +"\n" in line 41; 3. You dont actually need to print the sum of the salaries, you can delete lines 39,42 and 44. Now you program works as required. Another way of solving that doesn't involve defining a new Employee class is using a TreeMap<String, Double> that sorts the entries automatically and updating each duplicate entry using treeMap.replace(key, treeMap.getKey()+value). Then one can simply print to the console using the forEach method and lambdas, or a foreach loop.