please correct me where i'm going wrong??

Question about the task

Resolved

here's my code : I tried both of code in comments and after comment. public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String aa = reader.readLine(); String bb = reader.readLine(); String cc = reader.readLine(); String dd = reader.readLine(); int a = Integer.parseInt(aa); int b = Integer.parseInt(bb); int c = Integer.parseInt(cc); int d = Integer.parseInt(dd); System.out.println(max(a,b,c,d)); } //if (((a>b)&&(a>c))&&(a>d)){ //System.out.println(a); //} //else if (((c>b)&&(c>a))&&(c>d)){ //System.out.println(c); //} //else if (((b>a)&&(b>c))&&(b>d)){ //System.out.println(b); //} //else if (((d>b)&&(d>c))&&(d>a)){ //System.out.println(d); //} public static int max(int a, int b){ return a>b ? a : b; } public static int max(int a, int b, int c, int d){ int p = max(a>d); int q = max(c>d); return p>q ? p : q; } }

package com.codegym.task.task04.task0419; /* Maximum of four numbers */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String aa = reader.readLine(); String bb = reader.readLine(); String cc = reader.readLine(); String dd = reader.readLine(); int a = Integer.parseInt(aa); int b = Integer.parseInt(bb); int c = Integer.parseInt(cc); int d = Integer.parseInt(dd); System.out.println(max(a,b,c,d)); } //if (((a>b)&&(a>c))&&(a>d)){ //System.out.println(a); //} //else if (((c>b)&&(c>a))&&(c>d)){ //System.out.println(c); //} //else if (((b>a)&&(b>c))&&(b>d)){ //System.out.println(b); //} //else if (((d>b)&&(d>c))&&(d>a)){ //System.out.println(d); //} public static int max(int a, int b){ return a>b ? a : b; } public static int max(int a, int b, int c, int d){ int p = max(a>d); int q = max(c>d); return p>q ? p : q; } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Tata

Level 16 , Hisar, Haryana, India

16 May 2020, 18:10

first of all thank you Brandon for help. I know practice is everything and only coz of this i try everytime but this time i was stuck and coudn't able to catch that silly mistake. i am also feeling mistaken but not giving up. It's my passion and i do it just for myself not for anything else. And again thanks and namaste🙏.

Brandon

Level 9 , Toledo, United States

16 May 2020, 17:04

Well, I'm leaving for awhile, so I'm going to tell you the fix, in case you give up. So don't continue reading this if you're still trying to figure it out on your own. line 44 should be: int p = (max(a, b); line 45 should be: int q = max(c, d); using > in there is forcing it to try to return a boolean.

Brandon

Level 9 , Toledo, United States

16 May 2020, 16:29

Then you didn't fix lines 44-45. I was hoping you'd try to figure it out, because you'd learn better. If you just want the answer I can tell you that too..

Tata

Level 16 , Hisar, Haryana, India

16 May 2020, 16:26

check this image it's showing error after correction.

Tata

Level 16 , Hisar, Haryana, India

16 May 2020, 16:23

ok ,i check it now

Brandon

Level 9 , Toledo, United States

16 May 2020, 16:15

Not sure why you deleted the other question. If you're not using IntelliJ IDEA, you should. It will make things much clearer. Lines 44-45 are your issue. Also you're never testing int b. You're only testing a against d, and c against d, before testing those against each other.