Rebuilt this a couple of times but I can't seem to satisfy the last condition. Any help would be appreciated.

Question about the task

Under discussion

It outputs the max with positives and negatives. I've ran it through another compiler with N = 0 and N= negative, it returns nothing. I can't figure it out.

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); int n2 = n -1; int input = 0; int maximum = Integer.parseInt(reader.readLine()); if (n2>0){ for(; n2>0; n2--){ input = Integer.parseInt(reader.readLine()); if (input > maximum){ maximum = input; } } } if (n > 0){ System.out.print(maximum); } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Somdutt Dwivedi

Level 9 , Allahabad, India

2 June 2020, 19:44

everything seems to be alright but there is one logical error 1. suppose user entered N=0 your program must be terminated but it will wait for second input Hint : read N if(N>0) { // find maximum }

Laurence

Level 10

19 May 2020, 20:13

Interesting, what was your thought process behind the if-boolean-first part? whats thr purposr of 'first'? if (first) { maximum = a; first = false; }

Ashish RajAnand

Level 13 , Bhilai , India

19 May 2020, 02:10

just think if N = -5 or N =0 // your code must be stop . But your code was not stop and took a input from keyboard . that was maximum.

Brandon

Level 9 , Toledo, United States

19 May 2020, 01:43

I'm surprised this doesn't work. The only real difference I can see between this code, and mine (which passed) is that if I put in a number for N that is equal to, or less than 0, it doesn't wait for more input, before displaying nothing. It just ends. If you want I can post my code which passed, and you can reference it to try to make a working one.

Laurence

Level 10

19 May 2020, 09:56

That'd be great if you could get that could over to me somehow. Yeah I've tried implementing an if-exit after reading N but no luck.

Ashish RajAnand

Level 13 , Bhilai , India

19 May 2020, 15:47

post your code

Brandon

Level 9 , Toledo, United States

19 May 2020, 17:54

I'm sure it could be improved, but this code passed. Like I said the only real difference I can see is that mine ends immediately after n is entered at or below 0, while yours still waits for further input to set up your first "maximum" integer.

package com.codegym.task.task05.task0532;

import java.io.*;

/*
Task about algorithms

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int maximum=0;
        int count;
        boolean first = true;
        int n = Integer.parseInt(reader.readLine());
        if (n > 0) {


            for (count = 0; count < n; count++) {
                int a = Integer.parseInt(reader.readLine());
                if (first) {
                    maximum = a;
                    first = false;
                }

                maximum = (a > maximum ? a : maximum);
            }





            System.out.println(maximum);
        }else;

    }

}