Dont understand why my code is failing

Question about the task

Under discussion

I don't understand why my 2 validations are failing if I already have used 2 methods in solution class and its returning true for odd number odd days. Could you please help?

1. Implement the isDateOdd(String date) method so that it returns true if the number of days since the beginning of the year is odd, and otherwise returns false
2. String date is passed in the form: FEBRUARY 1 2013
Don't forget to account for the first day of the year.

Example:
JANUARY 1 2000 = true JANUARY 2 2020 = false

Requirements:

The program should display text on the screen.
The Solution class must have two methods.
The isDateOdd() method must return true if the number of days since the beginning of the year is odd, and must otherwise return false.
The main() method should call the isDateOdd() method.

package com.codegym.task.task08.task0827; import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.Calendar; import java.util.Date; import java.util.GregorianCalendar; import java.util.TimeZone; import java.util.function.Predicate; /* Working with dates */ public class Solution { public static void main(String[] args) throws ParseException { System.out.println(isDateOdd("JAN 3 2016")); //isDateOdd("MAY 1 2013"); } public static boolean isDateOdd(String date) throws ParseException { SimpleDateFormat dateFormat = new SimpleDateFormat("MMM dd yyyy"); Date d2 = dateFormat.parse("JAN 01 2016"); Date d1 = dateFormat.parse(date); float diff = (d1.getTime()-d2.getTime())/(1000*60*60*24); //Calendar cal = new GregorianCalendar(); System.out.println(d2); System.out.println(d1); System.out.println(diff); Predicate<Float> p1 = (days)->days%2!=0; if (p1.test(diff)) return true; else return false; // return true; } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Hafsah Jilanee

Level 10 , Karachi, Pakistan

24 October 2022, 12:29

package com.codegym.task.task08.task0827;

import java.util.Date;
import java.time.Year;
import java.text.SimpleDateFormat;
import java.util.Calendar;
/*
Working with dates

*/

public class Solution {
    public static void main(String[] args) {
        System.out.println(isDateOdd("MAY 1 2013"));
        //System.out.println(isDateOdd("JANUARY 2 2000"));
    }

    public static boolean isDateOdd(String date) {

        Date endDate = new Date(date);


        SimpleDateFormat df = new SimpleDateFormat("YYYY");

        int year = Integer.parseInt(df.format(endDate));
        //System.out.println(year);

        Calendar cal = Calendar.getInstance();
        cal.set(Calendar.YEAR, year-1);
        cal.set(Calendar.MONTH, 11);
        cal.set(Calendar.DATE, 30);

        Date startDate = cal.getTime();
        //System.out.println(startDate.getTime());
        //System.out.println(endDate.getTime());

        long milisec = endDate.getTime() - startDate.getTime();
        long days = ((milisec/1000)/(60*60*24));
        //System.out.println(days);

        if (days%2 == 0){
            return false;
        }
        else {

            return true;
        }
        //return true;

    }
}

Hafsah Jilanee

Level 10 , Karachi, Pakistan

24 October 2022, 12:29

here's how i did it

AnnemiekFF

Level 41 , Breda, Netherlands

19 May 2020, 12:44

Well....first of all, remember to remove all the System.out.println before you check it. Second....it should not throw an exception, so either capture it in a try-catch, or use for example the DateTimeFormatterBuilder() to build a dateTimeFormatter. (use google in that case).

Raj Mishra Java Developer at Sopra banking softwa

19 May 2020, 13:05

Changed the code as you said, but still failing: public static void main(String[] args) { System.out.println(isDateOdd("JAN 10 2016")); //isDateOdd("MAY 1 2013"); } public static boolean isDateOdd(String date) { SimpleDateFormat dateFormat = new SimpleDateFormat("MMM dd yyyy"); Date d2 = null; Date d1 = null; try { d2 = dateFormat.parse("JAN 01 2016"); d1 = dateFormat.parse(date); } catch (ParseException e) { e.printStackTrace(); } float diff = (d1.getTime()-d2.getTime())/(1000*60*60*24); //Calendar cal = new GregorianCalendar(); //System.out.println(d2); //System.out.println(d1); //System.out.println(diff); Predicate<Float> p1 = (days)->days%2!=0; if (p1.test(diff)) return true; else return false; // return true; }

AnnemiekFF

Level 41 , Breda, Netherlands

19 May 2020, 13:57

If you use LocalDate instead of date, you get a method that returns the days since the beginning of the year. Then you can simply check if that is even or uneven and return accordingly without need for calculating diff and manually creating a date for the first of 2016 (what if the day tested is in another year?).