I can get 3 criteria if i don't include the check for horizontal or vertical duplicates but the moment i include the line for this it only give me verification for first task. Any ideas please....

Question about the task

2048 (Part 14/18)

Under discussion

package com.codegym.games.game2048;

import com.codegym.engine.cell.*;

import java.util.ArrayList;
import java.util.Arrays;

public class Game2048 extends Game {

    //variables for class
    private static final int SIDE = 4; //size of screen
    private int[][] gameField = new int[SIDE][SIDE]; //gives each part of grid a location
    private boolean isGameStopped = false;

    //initializes game screen and begins game
    @Override
    public void initialize()
    {
        setScreenSize(SIDE, SIDE); //size of game
        createGame();
        drawScene(); //creates grid
    }

    private void createGame()
    {
        createNewNumber();//initial two numbers put in grid at start of game
        createNewNumber();


    }

    //sets game board and puts numbers in grid.
    private void drawScene()
    {

        for (int x = 0; x<SIDE; x++)
            for (int y = 0; y<SIDE; y++)
                setCellColoredNumber(x, y, gameField[y][x]); //prints number in grid

    }

    //creates a number, twice at beginning and each time player slides across grid and also finds the value of the max int on grid
    private void createNewNumber()
    {

            int x = getRandomNumber(SIDE); //initializing blank coordinates
            int y = getRandomNumber(SIDE);
            int z = getRandomNumber(10);
            //Sets a value to an empty coordinate within the grid at a 90% chance of 2 and 10% chance of a 4
            if (gameField[x][y] == 0) {
                if (z == 9)
                    gameField[x][y] = 4;
                else
                    gameField[x][y] = 2;
            } else createNewNumber();

        if (getMaxTileValue() == 2048)
            win();




    }

    //denotes color of each cell dependant on number value
    private Color getColorByValue(int value)
    {
        if (value == 0)
            return Color.ANTIQUEWHITE;
        else if (value == 2)
            return Color.LIGHTPINK;
        else if (value == 4)
            return Color.PURPLE;
        else if (value == 8)
            return Color.BLUE;
        else if (value == 16)
            return Color.LIGHTSEAGREEN;
        else if (value == 32)
            return Color.GREEN;
        else if (value == 64)
            return Color.LIGHTGREEN;
        else if (value == 128)
            return Color.ORANGE;
        else if (value == 256)
            return Color.CORAL;
        else if (value == 512)
            return Color.RED;
        else if (value == 1024)
            return Color.PINK;
        else
            return Color.DEEPPINK;

    }

    //sets color of cells based apon getColorByValue method
    private void setCellColoredNumber(int x, int y, int value)
    {
        if (value != 0)
            setCellValueEx(x, y, getColorByValue(value), Integer.toString(value) );
        else
            setCellValueEx(x, y, getColorByValue(value), "" );

    }
    //this method takes a row from the grid and then sorts empty fields to right and moves other
    //numbers to left without changing there order. This is only the beginning
    private boolean compressRow(int[] row) {
        boolean isChanged = false;

        for (int i = 0; i < row.length; i++)
        {
                for (int j = 1; j < row.length; j++)
                {
                    if (row[j-1] == 0)
                    {
                        if(row[j] != 0)
                         isChanged = true;
                         row[j-1] = row[j];
                         row[j] = 0; // had to use this way because creating temp array did not fit task conditions
                    }
                }

        }

        return isChanged; //variable used to discover whether the row was changed or not.
    }

    //puts adjoining cells of the same value together
    private boolean mergeRow(int[] row)
    {
       boolean isChanged = false;
       //int[] rowChange = new int[row.length];

           for(int j = 1; j<row.length; j++)
               if(row[j] == row[j-1] && row[j] != 0)
               {
                   isChanged = true; //changing variable
                   row[j - 1] = row[j] + row[j - 1];
                   row[j] = 0; //where there is a gap from combined numbers a zero is inuptted
               }
      return  isChanged;
    }

    @Override //pre-built method for keyboard input, we use it to "shift" our grid around
    public void onKeyPress(Key key)
    {
        if (key == Key.LEFT)
        {
            moveLeft();
            drawScene();
        }

        else if (key == Key.RIGHT)
        {
            moveRight();
            drawScene();
        }
        else if (key == Key.UP)
        {
            moveUp();
            drawScene();
        }
        else if (key == Key.DOWN)
        {
            moveDown();
            drawScene();
        }

    }

    //this method compresses and merges numbers if possible, checking each with a secondary boolean result and if either true creates a new number.
    private void moveLeft()
    {
        boolean compressed = false;
    boolean merged = false;
    boolean compressed2 = false;
    int move = 0; //counting integer to check movement on screen

        for (int i = 0; i < SIDE; i++)
        {

                compressed = compressRow(gameField[i]); //makes boolean results true
                merged = mergeRow(gameField[i]);
                compressed2 = compressRow(gameField[i]);

                if (compressed || merged || compressed2)//if either action returned true move + 1
                    move ++;
            }

            if (move != 0)
                createNewNumber();

        }


    private void moveRight()
    {
        boolean compressed = false;
        boolean merged = false;
        boolean compressed2 = false;
        int move = 0; //counting integer to check movement on screen
        rotateClockwise(); //As we have already set up the left move, by rotating the array we can
        rotateClockwise(); // implement the "slide-to-the-left" method

        for (int i = 0; i < SIDE; i++)
        {

            compressed = compressRow(gameField[i]); //makes boolean results true
            merged = mergeRow(gameField[i]);
            compressed2 = compressRow(gameField[i]);

            if (compressed || merged || compressed2)//if either action returned true move + 1
                move ++;
        }

        if (move != 0)
            createNewNumber();

        rotateClockwise();
        rotateClockwise();

    }


    private void moveUp()
    {
        boolean compressed = false;
        boolean merged = false;
        boolean compressed2 = false;
        int move = 0; //counting integer to check movement on screen

        rotateClockwise();
        rotateClockwise();
        rotateClockwise();
        for (int i = 0; i < SIDE; i++)
        {

            compressed = compressRow(gameField[i]); //makes boolean results true
            merged = mergeRow(gameField[i]);
            compressed2 = compressRow(gameField[i]);

            if (compressed || merged || compressed2)//if either action returned true move + 1
                move ++;
        }

        if (move != 0)
            createNewNumber();

        rotateClockwise();

    }


    private void moveDown()
    {
        boolean compressed = false;
        boolean merged = false;
        boolean compressed2 = false;
        int move = 0; //counting integer to check movement on screen
        rotateClockwise();
        for (int i = 0; i < SIDE; i++)
        {

        compressed = compressRow(gameField[i]); //makes boolean results true
        merged = mergeRow(gameField[i]);
        compressed2 = compressRow(gameField[i]);

        if (compressed || merged || compressed2)//if either action returned true move + 1
        move ++;
        }

        if (move != 0)
        createNewNumber();


        rotateClockwise();
        rotateClockwise();
        rotateClockwise();
    }

    private void rotateClockwise()
    {
        int[][] temp = new int[SIDE][SIDE];
        for (int i = 0; i < SIDE; ++i)
            for (int j = 0; j < SIDE; ++j)
                temp[i][j] = gameField[SIDE - j - 1][i];

        for (int i = 0; i < SIDE; ++i)
            for (int j = 0; j < SIDE; ++j)
                gameField[i][j] = temp[i][j];
    }

    //finds the max of the array
    private int getMaxTileValue()
    {
        int max = 0;
        for (int i = 0 ; i < SIDE; i++)
            for (int j = 0 ; j<SIDE; j++)
                if (gameField[i][j] > max)
                max = gameField[i][j];


         return max;
    }

    private void win()
    {
        isGameStopped = true;
        showMessageDialog(Color.GOLD, "You are a Winner!", Color.BLACK, 45);
    }

      private boolean canUserMove()
    {
        boolean movesLeft = false;
        //comparison loop, checking for empty cells and if all are full checking for  any duplicates when all spaces are taken.
        for (int i = 0 ; i < SIDE; i++)
            for (int j = 0 ; j<SIDE; j++)
            {
                if (gameField[i][j] == 0)
                {
                    movesLeft = true;
                }
                else if((i-1) > 0 && (gameField[i][j] == gameField[i-1][j]))
                {
                    movesLeft = true;
                }
                else if ((i+1) > 4 && (gameField[i][j] == gameField[i+1][j]))
                {
                    movesLeft = true;
                }
                else if ((j+1) < 4 && (gameField[i][j] == gameField[i][j+1]))
                {
                    movesLeft = true;
                }
                else if ((j-1)>0 && (gameField[i][j] == gameField[i][j-1]))
                {
                    movesLeft = true;
                }

            }

        return movesLeft;

    }




}

Great! In the last part, we identified the win conditions and implemented them.

But there's another side of the coin: loss. If the game board has no tile whose value is 2048 and no move can be made, then the player has lost.

A move can be made if there is at least one empty tile or there are no empty tiles but they can be merged.

Put these checks in the canUserMove() method.

Requirements:

The private boolean canUserMove() method must be created in the Game2048 class.
canUserMove() must return true if the number of zero elements in the gameField matrix is greater than zero.
canUserMove() must return true if there are no zero elements but the gameField matrix has at least two adjacent (horizontally or vertically) cells with the same value.
canUserMove() must return false if there are no empty tiles and no possible mergers.

package com.codegym.games.game2048; import com.codegym.engine.cell.*; import java.util.ArrayList; import java.util.Arrays; public class Game2048 extends Game { //variables for class private static final int SIDE = 4; //size of screen private int[][] gameField = new int[SIDE][SIDE]; //gives each part of grid a location private boolean isGameStopped = false; //initializes game screen and begins game @Override public void initialize() { setScreenSize(SIDE, SIDE); //size of game createGame(); drawScene(); //creates grid } private void createGame() { createNewNumber();//initial two numbers put in grid at start of game createNewNumber(); } //sets game board and puts numbers in grid. private void drawScene() { for (int x = 0; x<SIDE; x++) for (int y = 0; y<SIDE; y++) setCellColoredNumber(x, y, gameField[y][x]); //prints number in grid } //creates a number, twice at beginning and each time player slides across grid and also finds the value of the max int on grid private void createNewNumber() { int x = getRandomNumber(SIDE); //initializing blank coordinates int y = getRandomNumber(SIDE); int z = getRandomNumber(10); //Sets a value to an empty coordinate within the grid at a 90% chance of 2 and 10% chance of a 4 if (gameField[x][y] == 0) { if (z == 9) gameField[x][y] = 4; else gameField[x][y] = 2; } else createNewNumber(); if (getMaxTileValue() == 2048) win(); } //denotes color of each cell dependant on number value private Color getColorByValue(int value) { if (value == 0) return Color.ANTIQUEWHITE; else if (value == 2) return Color.LIGHTPINK; else if (value == 4) return Color.PURPLE; else if (value == 8) return Color.BLUE; else if (value == 16) return Color.LIGHTSEAGREEN; else if (value == 32) return Color.GREEN; else if (value == 64) return Color.LIGHTGREEN; else if (value == 128) return Color.ORANGE; else if (value == 256) return Color.CORAL; else if (value == 512) return Color.RED; else if (value == 1024) return Color.PINK; else return Color.DEEPPINK; } //sets color of cells based apon getColorByValue method private void setCellColoredNumber(int x, int y, int value) { if (value != 0) setCellValueEx(x, y, getColorByValue(value), Integer.toString(value) ); else setCellValueEx(x, y, getColorByValue(value), "" ); } //this method takes a row from the grid and then sorts empty fields to right and moves other //numbers to left without changing there order. This is only the beginning private boolean compressRow(int[] row) { boolean isChanged = false; for (int i = 0; i < row.length; i++) { for (int j = 1; j < row.length; j++) { if (row[j-1] == 0) { if(row[j] != 0) isChanged = true; row[j-1] = row[j]; row[j] = 0; // had to use this way because creating temp array did not fit task conditions } } } return isChanged; //variable used to discover whether the row was changed or not. } //puts adjoining cells of the same value together private boolean mergeRow(int[] row) { boolean isChanged = false; //int[] rowChange = new int[row.length]; for(int j = 1; j<row.length; j++) if(row[j] == row[j-1] && row[j] != 0) { isChanged = true; //changing variable row[j - 1] = row[j] + row[j - 1]; row[j] = 0; //where there is a gap from combined numbers a zero is inuptted } return isChanged; } @Override //pre-built method for keyboard input, we use it to "shift" our grid around public void onKeyPress(Key key) { if (key == Key.LEFT) { moveLeft(); drawScene(); } else if (key == Key.RIGHT) { moveRight(); drawScene(); } else if (key == Key.UP) { moveUp(); drawScene(); } else if (key == Key.DOWN) { moveDown(); drawScene(); } } //this method compresses and merges numbers if possible, checking each with a secondary boolean result and if either true creates a new number. private void moveLeft() { boolean compressed = false; boolean merged = false; boolean compressed2 = false; int move = 0; //counting integer to check movement on screen for (int i = 0; i < SIDE; i++) { compressed = compressRow(gameField[i]); //makes boolean results true merged = mergeRow(gameField[i]); compressed2 = compressRow(gameField[i]); if (compressed || merged || compressed2)//if either action returned true move + 1 move ++; } if (move != 0) createNewNumber(); } private void moveRight() { boolean compressed = false; boolean merged = false; boolean compressed2 = false; int move = 0; //counting integer to check movement on screen rotateClockwise(); //As we have already set up the left move, by rotating the array we can rotateClockwise(); // implement the "slide-to-the-left" method for (int i = 0; i < SIDE; i++) { compressed = compressRow(gameField[i]); //makes boolean results true merged = mergeRow(gameField[i]); compressed2 = compressRow(gameField[i]); if (compressed || merged || compressed2)//if either action returned true move + 1 move ++; } if (move != 0) createNewNumber(); rotateClockwise(); rotateClockwise(); } private void moveUp() { boolean compressed = false; boolean merged = false; boolean compressed2 = false; int move = 0; //counting integer to check movement on screen rotateClockwise(); rotateClockwise(); rotateClockwise(); for (int i = 0; i < SIDE; i++) { compressed = compressRow(gameField[i]); //makes boolean results true merged = mergeRow(gameField[i]); compressed2 = compressRow(gameField[i]); if (compressed || merged || compressed2)//if either action returned true move + 1 move ++; } if (move != 0) createNewNumber(); rotateClockwise(); } private void moveDown() { boolean compressed = false; boolean merged = false; boolean compressed2 = false; int move = 0; //counting integer to check movement on screen rotateClockwise(); for (int i = 0; i < SIDE; i++) { compressed = compressRow(gameField[i]); //makes boolean results true merged = mergeRow(gameField[i]); compressed2 = compressRow(gameField[i]); if (compressed || merged || compressed2)//if either action returned true move + 1 move ++; } if (move != 0) createNewNumber(); rotateClockwise(); rotateClockwise(); rotateClockwise(); } private void rotateClockwise() { int[][] temp = new int[SIDE][SIDE]; for (int i = 0; i < SIDE; ++i) for (int j = 0; j < SIDE; ++j) temp[i][j] = gameField[SIDE - j - 1][i]; for (int i = 0; i < SIDE; ++i) for (int j = 0; j < SIDE; ++j) gameField[i][j] = temp[i][j]; } //finds the max of the array private int getMaxTileValue() { int max = 0; for (int i = 0 ; i < SIDE; i++) for (int j = 0 ; j<SIDE; j++) if (gameField[i][j] > max) max = gameField[i][j]; return max; } private void win() { isGameStopped = true; showMessageDialog(Color.GOLD, "You are a Winner!", Color.BLACK, 45); } private boolean canUserMove() { boolean movesLeft = false; //comparison loop, checking for any duplicates when all spaces are taken. for (int i = 0 ; i < SIDE; i++) for (int j = 0 ; j<SIDE; j++) { if (gameField[i][j] == 0) movesLeft = true; if((gameField[i][j] == gameField[i+1][j]) || (gameField[i-1][j] == gameField[i][j]) || (gameField[i][j] == gameField[i][j+1]) || (gameField[i][j] == gameField[i][j-1])) movesLeft = true; } //System.out.println(movesLeft); return movesLeft; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

22 May 2020, 15:40

You solved this similar to mine, however here are a couple of tips. Inside the canUserMove() method: #1 When the code finds a true condition it should break the loop. Lets say the very first value at [0][0] is found to equal 0, which would mean there are moves left, there would be no reason to check the remaining squares. It's sort of like looking for your car keys, finding them, then continuing to look for them in all the other places they could be. #2 In the code above, the double for loop is starting at [0][0] and then moving progressively along the x axis until it reaches the end and then goes to the next number progressively along the y axis. So it does this 0,1 0,2 0,3 1,0 1,1 1,2 1,3 2,0 2,1 etc... Logically, you only need to check +1 to x and +1 to the y. Moving progressively you do not need to check -1 to x and y because it would equal an earlier check. So, when you are 0,0 you would check 1,0 and 0,1. When you reach 1,0 and 0,1 you do not need to recheck 0,0. You can safely remove both the -1 checks. #3 As you have discovered, your code can access "out of bounds" indices which are causing the code to crash. To prevent this, also assuming you took my #2 tip, just make sure that adding +1 to x or y does not equal SIDE (which would be out of bounds). I hope this helps.

Steve Bennett

Level 18 , Stoneleigh

27 May 2020, 15:50

yes I got there eventually , I wasn't as efficient as your recommendation. I still checked each square but only if a tile exists.

private boolean canUserMove()
   {
       boolean movesLeft = false;
       //comparison loop, checking for empty cells and if all are full checking for  any duplicates when all spaces are taken.
       for (int i = 0 ; i < SIDE; i++)
           for (int j = 0 ; j<SIDE; j++)
           {
               if (gameField[i][j] == 0)
               {
                   movesLeft = true;
               }
               //this if statement checks if there is an above cell has it got the same value in it.
               if((i-1) > 0 && (gameField[i][j] == gameField[i-1][j]))
               {
                   movesLeft = true;
               }
               //this checks for DOWN
               if ((i+1) < SIDE && (gameField[i][j] == gameField[i+1][j]))
               {
                   movesLeft = true;
               }
               //this checks for RIGHT
               if ((j+1) < SIDE && (gameField[i][j] == gameField[i][j+1]))
               {
                   movesLeft = true;
               }
               //this checks for LEFT
               if ((j-1)>0 && (gameField[i][j] == gameField[i][j-1]))
               {
                   movesLeft = true;
               }

           }

Many Thanks

Steve Bennett

Level 18 , Stoneleigh

22 May 2020, 08:53

I see stupidly that when i try and check adjacent squares , i can possibly check out of my screen size. I just can't think how to write the logic to check adjacent positions