I don't know what I'm doing anymore

Domanda sul compito

Risolta

in my mind if a number smaller than 0 was entered, the variable b would increase, in the final case if the variable b had increased then a number smaller than or equal to 0 was inserted and therefore it did not have to print anything currently, however, I only find number 6 printed and not the maximum I know, it's a circle of things, but I couldn't think of anything else

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requisiti:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int N = Integer.parseInt(reader.readLine()); int b=0; int maximum = 0; for(int i=0; i<N; i++){ int a = Integer.parseInt(reader.readLine()); if(a>0){ if(a>maximum){ maximum=a; } else{ maximum=maximum;; } } else{ b=b+1; break; } } if(b>0){ System.out.println(""); } else{ System.out.println(maximum); } //PARTE FINALE } }

Commenti (3)

Popolari
Nuovi
Vecchi

Devi avere effettuato l'accesso per lasciare un commento

Thomas

Livello 41 , Bayreuth, Germany

18 giugno, 06:42

You are supposed to find the maximum number among a bunch of numbers. To be able to determine the max, you need to have some numbers you can look at. So the number count needs to be greater than zero. The numbers itself may be positive or negative. That said, n has to be > 0, the numbers itself can be any int. Now let's dig into the code. 1. read in N

Scanner console = new Scanner(System.in);
int N = console.nextInt();

2. Very important now is that one requirement: 'The program should not display anything if N is less than or equal to 0.' That's the do all or nothing requirement (as a sidenote, you read in N numbers and you pring a linebreak if N < 0). You can directly code that similiar to:

if (N <= 0) {
    // do nothing
} else {
    // code to execute
}

3. Now read in 3 numbers and determine the max and print the latter. I'm sure you know how to do that and just add comments to the above code

if (N <= 0) {
    // do nothing
} else {
    // read in N numbers
    // determine max
    // print max
}

4. optimize code We have an empty body in the conditino N <= 0 and that does not look to nice. It also means, that the if body is superfluous and we only need the body of the else part. If we now rething the condition we could do with just one body. That can be achieved if you negate the condition, like (!{N <= 0)) or simply (N > 0).

Scanner console = new Scanner(System.in);
int N = console.nextInt();
if (N > 0) {
    // read in N numbers
    // determine max
    // print max
}
// do nothing anymore

Anonymous #11525567

Livello 13 , Brescia, Italy

18 giugno, 08:06

Apparently before learning Java I have to learn English better, I understood the whole thing very badly, now it makes sense, thank you very much

Thomas

Livello 41 , Bayreuth, Germany

18 giugno, 09:41

The requirements of this task are not very clear for many students. Even in the localized versions, the description is often misunderstood. So there is no need to worry. After all, you are here to learn and not to know already ;)