Timer runs out on this solution, works when testing. Any reason why?

Vraag over de taak

Wordt bediscussieerd

package com.codegym.task.task04.task0420; /* Sorting three numbers */ import java.io.*; import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { //write your code here Scanner scanner = new Scanner(System.in); int a = scanner.nextInt(); int b = scanner.nextInt(); int c = scanner.nextInt(); int d = 0; while (a > b || a > c || b > c) { if (a > b) { d = a; a = b; b = d; if (a > c) { d = a; a = c; c = d; if (b > c) { d = b; b = c; c = d; } } } } System.out.println(a + " " + b + " " + c); } }

Opmerkingen (1)

Populair
Nieuw
Oud

Je moet ingelogd zijn om opmerkingen te kunnen maken

Thomas

Niveau 41 , Bayreuth, Germany

20 July 2022, 05:48

Your idea is good. The validation process times out cause you probably didn't test with all combinations. You can find a combination yourself if you look at your while conditin. Think about some numbers that keep it true but don't pass your if conditions and you have 3, 1, 2. I'd suggest to get rid of the while loop and all the nested conditions altogether as this makes things error prone. You do not need a complex solution for three numbers. Go the easy way. 1. step try if a > b -> yes, swap 2. step try if b > c -> yes, swap 3. step look at a and b again. cause b changed it can b > a again, test this if a > b -> swap it that's all, just three if conditions in series. Oh, and I also suggest to name temporary variables just this, temp or tmp. This makes your code more readable. You have your three nums a, b, c and temp that you use to swap Another funny approach would be to find min and max. You could use methods you coded before. Then you get the middle number if you add all nums and deduct min and max from the sum.