Close to finish, need help.

Pytania dotyczące zadania

Zadanie z algorytmami

Składnia Java, Poziom 5, Lekcja 12

Dyskutowane

Can't find a reason why it's not approved. Please help me.

package pl.codegym.task.task05.task0532; import java.io.*; /* Zadanie z algorytmami */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int maksimum; int n = Integer.parseInt(reader.readLine()); maksimum = n; if (n>0){ for(int a=n;a>=1;a--){ int b = Integer.parseInt(reader.readLine()); if(b>maksimum){ maksimum=b; } } System.out.println(maksimum); } } }

Komentarze (3)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

piotr08

Poziom 6 , Krakow

13 listopada 2020, 12:21

mamy identyczne rozwiazanie, wg Nouser wystarczy dac maksiumum = 0; wtedy nie bedzie bralo pod uwage pierwszej liczby ktora okresla ilosc liczb. ale to dalej nie dziala

Nouser

Poziom 36 , Germany

13 listopada 2020, 13:14

setting maximum to 0 is not sufficient... please reread my below answer or check this code, sometimes it's easier to understand things when beeing able to look at them.

//declare some variables
BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
//the maximum, we need to initialize it either
//a) 0 and later set it to the first input. If we leave it 0, then the input
//of all negative numbers will lead to an erroneous output
//b) we set it to Integer.MIN_VALUE; so every comparison to a value greater than
// the minimum possible integer value sets maximum to the new value

//possibility a)
int maximum = 0;
//possibility b)
//int maximum = Integer.MIN_VALUE;
int number; //the input

//input N (count)
int count = Integer.parseInt(reader.readLine());
//if N (count) > 0 do some magic
if (count > 0) {
    //loop so N (count) numbers can be entered by the user
    for (int i = 0; i < count; i++) {
        //save the entered number in the number variable
        number = Integer.parseInt(reader.readLine());
        //here we set maximum to the first input. When using possibility b) this is not necessary
        if (i == 0) maximum = number;
        //if maximum > number set maximum to maximum, else set maximum to number
        maximum = maximum > number ? maximum : number;
    }

    System.out.println(maximum);
} //end count > 0

Nouser

Poziom 36 , Germany

4 maja 2020, 14:13

maksimum = n; is the problem. The maximum you should calculate from n read numbers exclusive n. Try something like maksimum = Integer.MIN_VALUE; or set the first read number to max (if a == n) maksimum = b;