GCD

if(!( a > 0 || b > 0)) is a NO-NO but if( a < 1 || b < 1) is ok! 😡😤

i knew about Euclidian algorithm so it took me 3 minutes to write a code to find GCD, and after that... it took me 20 minute to understand what they want from me on the second requirement. in my opinion this requirement was wrote very bad that's why i will say here what's the problem, if you don't want a direct suggestion don't read this. let's say you ask the user to enter 2 numbers (a and b) you may be tempted to write the code to react if the user will introduce a string or a double or a negative number, well they don't care about that. after the user input they just want you to check if a and b are bigger than zero (throw an exception if not), that's all. is true the program will throw an exception by itself if you try to enter a string but still... i think that point is very bad wrote and after you find the best way to find a GCD is really frustrating to lose so much time for that exception...

Why always return first? If second is bigger than first why should we return first?

Created 3 arrays, one to populate a%i==0, other b%i==0, used third array to populate with duplicate elements with nested for loop, max of third array is GCD https://en.wikipedia.org/wiki/Greatest_common_divisor

Two extremely helpful hints: 1. You don't need to catch the exception, you just need to throw one if one of the numbers is not positive (zero is not positive). 2. Ignore the part of requirement 2 that says "If the entered lines can't be converted to positive integers", it should say "If the entered lines are not positive integers (zero is not considered positive)". If you follow this requirement down the converted path you will try Math.abs() and that will mess everything up. The rest of this task is straight forward as long as you interpret requirement #2 with the hints above.

The second requirement was confusing, I approached it assuming that the input would not be an integer.

This one honestly made me sad. I coded finding the GCD without googling first. I was fairly proud of my approach, as it was 100% self derived. even created my own exception class, felt pretty darn clever. then failed the 2nd requirement about a zillion times. As someone mentioned, the explanation there needed to be more specific. it is hard to gauge what's wrong when the required output looks exactly like your own.

There needs to be a much better explanation as to what is expected by throwing an exception on this one.

What did you return if there is no GCD? For example if the inputs were: 10 3

I don't see the problem here, but I always get a Time out! when I try to do the validation... Any suggestions on why that happens?