hello, can someone tell me why it doesn't match the 5th condition?

Pregunta sobre la tarea

Resuelta

I tried it with different "N" numbers, and it works perfectly. thanks

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requisitos:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int maximum= 0; int temporal = 0; int N = Integer.parseInt(reader.readLine()); if (N<=0) return; for (int i=0; i<N; i++ ){ int current = Integer.parseInt(reader.readLine()); if (current > maximum){ maximum = current; } } // int a = /* int a = Integer.parseInt(reader.readLine()); int a = Integer.parseInt(reader.readLine()); int a = Integer.parseInt(reader.readLine()); int a = Integer.parseInt(reader.readLine()); */ System.out.println(maximum); } }

Comentarios (5)

Populares
Nuevas
Antiguas

Debes iniciar sesión para dejar un comentario

Guadalupe Gagnon

Nivel 37 , Tampa, United States

5 noviembre 2021, 20:35

I tried it with: 3 -5 -8 -4 It output the maximum was 0, but the maximum should have been -4. There seems to be an error in the program logic.

Anonymous #10862928

Nivel 10 , Spain

8 noviembre 2021, 17:55

Thanks Guadalupe, I see the error is that I make "maximum" to be 0 at the begining, so, i f you use negative numbers, they will never be >0 and will never fit the condition current> maximum. I'm trying to solve it, thanks for the hint.

Anonymous #10862928

Nivel 10 , Spain

8 noviembre 2021, 17:58

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int maximum= 0; //int temporal; int N = Integer.parseInt(reader.readLine()); if (N<=0) return; for (int i=0; i<N; i++ ){ int current = Integer.parseInt(reader.readLine()); maximum = current; if (current > maximum){ maximum = current; } } System.out.println(maximum); } }

Anonymous #10862928

Nivel 10 , Spain

8 noviembre 2021, 17:58

I got it, I just had to make maximum = current at the begining of the loop as welll, so that i'm sure thath value is never going to stay as 0. thank you so much :)

Jeongmin

Nivel 8 , Tsche-mul-p-ho, Korea, Republic of

17 diciembre 2021, 13:26

The first input shall be considered as the maximum before the next number is entered. package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); int maximum = 0; //write your code here if (n <= 0) return; for (int i=0; i < n; i++){ int number = Integer.parseInt(reader.readLine()); if (i == 0) maximum = number; else maximum = Math.max(number, maximum); } System.out.println(maximum); } }