- java help on CodeGym

CodeGym/Pomoc z zadaniami Java/

Magda

Poziom 10

Poland

02.03.2023
132widoki
1komentarz

Pytania dotyczące zadania

Ruszamy na cały kraj

Składnia Java, Poziom 8, Lekcja 11

Dyskutowane

However it works both in here and IntelliJ, the last requirement is not met.

package pl.codegym.task.task08.task0823; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.*; /* Ruszamy na cały kraj */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s = reader.readLine(); //tutaj wpisz swój kod ArrayList<Character> characters = new ArrayList<>(); for (int i=0; i<s.length(); i++) { characters.add(s.charAt(i)); } char first = Character.toUpperCase(characters.get(0)); characters.set(0, first); for (int i=0; i< characters.size(); i++) { if (characters.get(i).equals(' ') && !characters.get(i-1).equals(' ')) { char up = Character.toUpperCase(characters.get(i+1)); characters.set(i+1, up); } } //characters.toString(); for(int i=0; i< characters.size(); i++) { System.out.print(characters.get(i)); } } }

Komentarze (1)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Thomas

Poziom 41 , Bayreuth, Germany

2 marca 2023, 22:24

when there is a i - 1 or i + 1 in a loop then you need to be really careful not to run into an outOfBoundsException. In your code the i -1 is checked when the first condition is true, the current character is a space. If you now imagine the first character to be a space (i == 0), then your code will check the index -1 and that will give you the mentioned exception. Usually you use a collection when you need it's functionality. Here you do not make use of that. You could either iterate over the string and look at the current char using the String.charAt(index) method or you convert the string into a char array and iterate over that with String.toCharArray() But of course you can stay with the collection and maybe instead you get rid of looking ahead or behind inside the loop. You could save the previous char in a variable and use it in the next iteration to compare to. like

char prev = ' ';
for (int i=0; i< characters.size(); i++) {
        if (prev == ' ')
            characters.set(i, Character.toUpperCase(characters.get(i)));
        prev = characters.get(i);
}

that's a toCharArray approach also using the above mentioned technique with remembering the previous char

String s = "sam i am.";
char[] c = s.toCharArray(); // use a char array or String.charAt()

char prev = ' ';
for (int i = 0; i < c.length; i++) {
    if (prev == ' ' && c[i] >= 'a' && c[i] <= 'z') // or instead of a - z use Character.isLowerCase(c[i])
       c[i] -= 32; // for a - z or c[i] = Character.toUpperCase(c[i]); for all lowercase chars
    prev = c[i];
}

System.out.println(c);