Correct me if I'm wrong. Suggestions required

Pytania dotyczące zadania

Dyskutowane

If this error appears because of comparing index 0 and index 1 -> print max of those 2, increment and comparing next pair and so on? Any suggestions folks? Appreciate all feedback.

package pl.codegym.task.task05.task0532;

import java.io.*;
import java.util.ArrayList;
import java.util.Scanner;

/*
Zadanie z algorytmami
*/

public class Solution {
    public static void main(String[] args) throws Exception {
        Scanner scanner = new Scanner(System.in);
        ArrayList<Integer> list = new ArrayList<Integer>();

        int size = scanner.nextInt();

        for (int i = 0; i < size; i++) {
            int number = scanner.nextInt();
            list.add(number);

            int maksimum = list.get(i);


            if (maksimum == list.get(i)) {
                maksimum = number;
            } else {
                maksimum = list.get(0);
            }
            System.out.println(maksimum);
        }
    }


}

package pl.codegym.task.task05.task0532; import java.io.*; import java.util.ArrayList; import java.util.Scanner; /* Zadanie z algorytmami */ public class Solution { public static void main(String[] args) throws Exception { Scanner scanner = new Scanner(System.in); ArrayList<Integer> list = new ArrayList<Integer>(); int size = scanner.nextInt(); for (int i = 0; i < size; i++) { int number = scanner.nextInt(); list.add(number); int maksimum = list.get(i); if (maksimum == list.get(i)) { maksimum = number; } else { maksimum = list.get(0); } System.out.println(maksimum); } } }

Komentarze (3)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Guadalupe Gagnon

Poziom 37 , Tampa, United States

1 maja 2020, 15:14

przydatny

A couple problems: #1 the program should only have 1 output, the max of the entered numbers. This program has as many outputs as there are loop cycles (N). #2 The algorithm used inside the loop will not work. It creates variable "maksimum" every loop cycle on line 22 and sets it to the current input. Because it is set to the current input every time, on line 25 when it checks if it equals the current input the result will always be true, which then sets "maksimum" again to the current input. Then it outputs "maksumum" (which equals the current input) on line 30. You are going to need to fix these two issues to pass this task.

Błażej Ka

Poziom 17 , Poznan, Poland

1 maja 2020, 15:40

And now - this issue with last condition ? That's ridiculous :/

package pl.codegym.task.task05.task0532;

import java.io.*;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Scanner;

/*
Zadanie z algorytmami
*/

public class Solution {
    public static void main(String[] args) throws Exception {
        Scanner scanner = new Scanner(System.in);
        ArrayList<Integer> list = new ArrayList<Integer>();

        int size = scanner.nextInt();

        for (int i = 0; i < size; i++) {
            int number = scanner.nextInt();
            list.add(number);
        }
        int maksimum = Collections.max(list);

        if (size <= 0) {
        } else {
            System.out.println(maksimum);
        }
    }
}

Guadalupe Gagnon

Poziom 37 , Tampa, United States

1 maja 2020, 17:28

In this code, if you enter 0 for N there will be a "NoSuchElementException" thrown from line 23.