why it doesn't work ?

Pytania dotyczące zadania

Dyskutowane

I can't check my output bcs I don't know how to check it in Intelij :( can smb tell me what is wrong and maybe some hints :)

package pl.codegym.task.task18.task1804; import java.io.FileInputStream; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.*; /* Najrzadziej występujące bajty */ public class Solution { public static void main(String[] args) throws Exception { HashMap<Integer, Integer> mapa = new HashMap<Integer, Integer>(); ///mapa ArrayList<Integer> lista = new ArrayList<>(); ///lista /// z konsoli i do File readera BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String fileName = reader.readLine(); reader.close(); FileInputStream inputStream = new FileInputStream(fileName); /// maxymalna int temp = inputStream.read(); int max = temp; ///obliczanie max i dodawanie do listy while(temp > 0){ if(!lista.contains(temp)) mapa.put(temp,1); else{ int Value = mapa.get(temp); mapa.put(temp, Value+1); } if(temp > max) max = temp; temp = inputStream.read(); lista.add(temp); } inputStream.close(); for(Integer iteror : mapa.keySet()){ if(max == mapa.get(iteror)){ System.out.print(mapa.get(iteror)+ " "); } } }}

Komentarze (3)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Nouser

Poziom 36 , Germany

2 maja 2020, 16:52

maybe that way?

for (Map.Entry<Integer, Integer> pair : mapa.entrySet()) {
    if (pair.getValue() == min)
        System.out.print(pair.getKey() + " ");

Msaters

Poziom 20 , Legnica, Poland

2 maja 2020, 18:05

Thank you very much for feedback but still the same problem "do not display the same byte couple times" I think it's problem with my line 29 bcs I put to my Map sometimes the same key but idk the code after changes changes import java.io.FileInputStream; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.*; /* Najrzadziej występujące bajty */ public class Solution { public static void main(String[] args) throws Exception { HashMap<Integer, Integer> mapa = new HashMap<Integer, Integer>(); ///mapa ArrayList<Integer> lista = new ArrayList<>(); ///lista /// z konsoli i do File readera BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String fileName = reader.readLine(); reader.close(); FileInputStream inputStream = new FileInputStream(fileName); /// maxymalna int temp = inputStream.read(); int min = temp; ///obliczanie max i dodawanie do listy while(temp > 0){ if(!lista.contains(temp)) mapa.put(temp,1); else{ int Value = mapa.get(temp); mapa.put(temp, Value+1); } if(temp < min) min = temp; temp = inputStream.read(); lista.add(temp); } inputStream.close(); ///wypisywanie for (Map.Entry<Integer, Integer> pair : mapa.entrySet()) { if (pair.getValue() == min) System.out.print(pair.getKey() + " "); }}}

Nouser

Poziom 36 , Germany

2 maja 2020, 19:44

I'd suggest to start over from FileInputStream inputStream ... on. The rest is to complicated and that's cause you started with reading data outside the while loop. while (inputStream.available() > 0) { read ... or if ((temp = inputStream.read()) != -1) ... would give a nice start, then check if the data is already in the map, if yes, value++, if no, new entry with value 1. finally check if the added value is > max and update that if necessary Oh, and check out this int min = Byte.MAX_VALUE; int max = Byte.MIN_VALUE;