Program runs fine

Question about the task

Under discussion

I've tested manually all given scenarios and they work just fine. I think there is a problem with this solutions testing requirements

Use the keyboard to enter three integers. Display the number of positive and negative numbers in the original set in the following form: "Number of negative numbers: a", "Number of positive numbers: b", where a and b are the relevant values.

Examples:
a) if you enter the numbers:
2 5 6
then we display:
Number of negative numbers: 0 Number of positive numbers: 3

b) if you enter the numbers:
-2 -5 6
then we display:
Number of negative numbers: 2 Number of positive numbers: 1

Requirements:

The program should read the numbers from the keyboard.
The program should display text on the screen.
The program should display the number negative numbers in the original set.
The program should display the number of positive numbers in the original set.
If there are no negative numbers, the program should display "Number of negative numbers: 0".
If there are no positive numbers, the program should display "Number of positive numbers: 0".
Note that "0" is not a positive or negative number.

package en.codegym.task.jdk13.task04.task0429; import java.io.BufferedReader; import java.io.InputStreamReader; /* Positive and negative numbers */ public class Solution { static int counter = 0; static int negativeCounter = 0; public static void main(String[] args) throws Exception { InputStreamReader reader = new InputStreamReader(System.in); BufferedReader br = new BufferedReader(reader); int number1 = Integer.parseInt(br.readLine()); int number2 = Integer.parseInt(br.readLine()); int number3 = Integer.parseInt(br.readLine()); checkNumber(number1); checkNumber(number2); checkNumber(number3); System.out.println("Number of negative numbers: " + negativeCounter); System.out.println("Number of positive numbers: " + counter); } static void checkNumber(int number) { if (number > 0) { counter++; } else if (number < 0) { negativeCounter++; } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

24 April, 13:46

set lines 11 and 12 to 0 inside the main method:

public static void main(String[] args) throws Exception {
   counter = 0;
   negativeCounter = 0;
   // rest of code
}

This is because the validator tests your code multiple times. I don't work for codegym but my theory is that the validator is a program that loads your code in for the purpose of testing it. Variables that are static do not reset as long as the program that originally calls the class is not reset. So as long as the validator is testing your code those variables will not reset and keep increasing. For example, if they test your code with these set of numbers: [2, 5, 6] [-2, 5, -6] [2, 0, 0] [0, -5, 6] After the first three numbers your code would have the correct amounts; but then it would test the next set of numbers and that count would be added to the previous count and your output would be wrong. It would be incorrect for all the tests past the first one no matter what the tests were.