Second requirement

Pytania dotyczące zadania

Dyskutowane

Hi, The code works perfectly fine on my IDE but the second requirement is not met. Can someone point out what is wrong with my code? Thanks :)

package pl.codegym.task.task13.task1318; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.Scanner; import java.io.FileInputStream; /* Wczytywanie pliku */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String path = reader.readLine(); String s = ""; FileInputStream file = new FileInputStream(path); while (file.available() > 0) { int dane = file.read(); char ch = (char) dane; s += ch; } System.out.println(s); file.close(); reader.close(); } }

Komentarze (6)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Thomas

Poziom 41 , Bayreuth, Germany

19 października 2022, 13:36

przydatny

maybe cause of println(), it adds an additional new line character

mike3321

Poziom 25 , Warsaw, Poland

19 października 2022, 13:39

I've changed it to print() and it still doesn't pass second requirement

Thomas

Poziom 41 , Bayreuth, Germany

19 października 2022, 14:00

przydatny

next thing you can try is to get rid of String concatenation and output the char directly (inside the loop). Concatenation can use up quite some memory if it is a bigger file they test with

mike3321

Poziom 25 , Warsaw, Poland

21 października 2022, 09:20

I've changed it as you said but still no change. Code looks like that right now :

BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
       String path = reader.readLine();

       FileInputStream file = new FileInputStream(path);

       while (file.available() > 0) {
           int dane = file.read();
           System.out.print((char)dane);
       }

       file.close();
       reader.close();

Thomas

Poziom 41 , Bayreuth, Germany

21 października 2022, 10:13

przydatny

I just looked up my solution(s) and it is pretty much what you have

try (BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
     InputStream inputStream = new FileInputStream(reader.readLine())) {

    while (inputStream.available() > 0)
        System.out.print((char)inputStream.read());
    // while loop alternative
    // for (int data; (data = inputStream.read()) != -1; System.out.print((char) data));
}

My other approach is using a byte buffer. So it is different. I'd reset the task. Maybe the validator has a hickup. Then try your current code again. (And ignore the try blocks, they just replace the close methods here) // my 2nd approach

try (BufferedReader console = new BufferedReader(new InputStreamReader(System.in));
     FileInputStream in = new FileInputStream(console.readLine())) {

    byte[] buf = new byte[1024 * 8];
    for (int length; (length = in.read(buf, 0, buf.length)) > 0;)
        for (int i = 0; i < length; i++)
            System.out.print((char) buf[i]);
}

mike3321

Poziom 25 , Warsaw, Poland

24 października 2022, 07:43

So I've reset the task both on IDE and on the CodeGym website. Than I've tried to run my old solution, unfortunately with no improvement. I've also tried your approach with byte[] and two loops but it didn't pass verification as well. Maybe the validator has a hickup as you said. Thank you for all your comprehensive responses Thomas :)