What I'am missing??

Pytania dotyczące zadania

Wczytywanie pliku

Podstawy Java, Poziom 3, Lekcja 11

Dyskutowane

What I'am missing??

package pl.codegym.task.task13.task1318; import java.io.*; import java.nio.charset.StandardCharsets; import java.util.Scanner; /* Wczytywanie pliku */ public class Solution { public static void main(String[] args) throws Exception{ BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String pathName = "c:\\Zico\\"; FileInputStream fis; try { String fileName = reader.readLine(); fis = new FileInputStream(pathName + fileName); int data; while (fis.available() > 0) { data = fis.read(); System.out.print((char) data); } fis.close(); }catch (FileNotFoundException | NullPointerException e) { System.out.println(e); } reader.close(); } }

Komentarze (4)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Krystian

Poziom 29 , Poland, Poland

6 sierpnia 2023, 14:56

Thanks for fast answer i change this in 2 task, similar task, one was with read data (task 1318) from file, error The program hast show data from file second to write data (task 1319)from file. error The program has to write absolute all line and still i have task failed. It's funny because on my intellij works fine.

Thomas

Poziom 41 , Bayreuth, Germany

6 sierpnia 2023, 15:36

Another thing you should keep in mind is to not output anything the task does not ask for. Even line 33 may be to much. Usually I either do not catch the exception and instead add a throws xyz to the method definition (like you already have) or I rethrow the exception as RuntimeException

public static void main(String[] args) {
    // Solution using a byte buffer
    try (BufferedReader console = new BufferedReader(new InputStreamReader(System.in));
         FileInputStream in = new FileInputStream(console.readLine())) {

        byte[] buf = new byte[1024 * 8];
        for (int length; (length = in.read(buf, 0, buf.length)) > 0;)
                System.out.print(new String(buf, 0, length));

    } catch (IOException ioe) {
        throw new RuntimeException(ioe);
    }
}

using throws in method definition

public static void main(String[] args) throws IOException {
    try (BufferedReader console = new BufferedReader(new InputStreamReader(System.in));
         FileInputStream in = new FileInputStream(console.readLine())) {

        for (int c; (c = in.read()) != -1; System.out.print((char) c)) ;
    }
}

that's not really an exception handling you should do in real programs but most times works for CG. Most times an exception.printStackTrace() works as well

Krystian

Poziom 29 , Poland, Poland

7 sierpnia 2023, 10:34

Thanks, today i try to change and play with code.

Thomas

Poziom 41 , Bayreuth, Germany

6 sierpnia 2023, 14:24

the filename includes the path, so just try to remove line 16 and 'pathName + ' in line 22 if you add your 'hardcoded' path and validation passes it's own path+filename into the input then it will result in a file not found (like that made up example: c:/Zico/validation/inputs/task1318/test1.txt)