the last condition fails

Frage zur Aufgabe

Archiviert

Hi, maybe someone smarter than me could tell me. What i have done wrong here. Best regards Steffen P.S. Sorry for my english it's not my native language.

package de.codegym.task.task08.task0823; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; /* Landesweite Restaurantkette */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s = reader.readLine(); //schreib hier deinen Code String[] x = s.split("\\s+");//new String[s.length()]; //x = s.split("\\s+"); for(int i = 0; i < x.length; i++){ if(Debug.debug){ System.out.println(x[i]); } x[i] = x[i].replace(x[i].charAt(0),Character.toUpperCase(x[i].charAt(0))); if(Debug.debug){ System.out.println(x[i]); } } for(String y : x){ y = y + " "; System.out.print(y); } } public static class Debug{ public static boolean debug = false; } }

Kommentare (9)

Beliebt
Neu
Alt

Du musst angemeldet sein, um einen Kommentar schreiben zu können

Guadalupe Gagnon

Level 37 , Tampa, United States

1 April 2020, 19:13

Line 24: the replace method is replacing all characters that match the first argument (which is the first letter of each word). Words like "dad" would become "DaD", or "gaggle" would become "GaGGle". You are going to need to figure out another way of making sure only the first letter is capitalized.

Steffen Neumann

Level 14 , Ilfeld/ München, Deutschland

2 April 2020, 12:27

Okay, i corected this error, but i get still that the fourth condition is false. Even with my new code.

BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        String s = reader.readLine();

        //schreib hier deinen Code
        String[] x = s.split("\\s+");//new String[s.length()];
        x = s.split("\\s+");

        for(int i = 0; i < x.length; i++){
            if(Debug.debug){
                System.out.println(x[i]);
            }
            x[i] = x[i].replaceFirst(Character.toString(x[i].charAt(0)),Character.toString(Character.toUpperCase(x[i].charAt(0))));
            if(Debug.debug){
                System.out.println(x[i]);
            }
        }

        for(String y : x){
            y = y + " ";
            System.out.print(y);
        }

Guadalupe Gagnon

Level 37 , Tampa, United States

2 April 2020, 16:26

not get rid of the extra space at the end

Steffen Neumann

Level 14 , Ilfeld/ München, Deutschland

2 April 2020, 18:39

That doesn't help. I still get this error. I changed the way how i print the modified string. (I think it has something to do with the way i modify the input string. But I am not sure)

public static void main(String[] args) throws IOException {
    BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
    String s = reader.readLine();

    //schreib hier deinen Code
    String[] x = s.split("\\s+");//new String[s.length()];
    x = s.split("\\s+");

    for(int i = 0; i < x.length; i++){
        if(Debug.debug){
            System.out.println(x[i]);
        }
        x[i] = x[i].replaceFirst(Character.toString(x[i].charAt(0)),Character.toString(Character.toUpperCase(x[i].charAt(0))));
        if(Debug.debug){
            System.out.println(x[i]);
        }
    }

    //for(String y : x){
    for(int k = 0; k < x.length - 1 ; k++){
        x[k] = x[k];
        System.out.print(x[k] + " ");
        if(Debug.debug){
            System.out.println("");
            System.out.println("Debug: " + x[k]);
        }
    }
    System.out.println(x[x.length - 1]);
}

Basti

Level 10 , Germany

10 April 2020, 10:16

In case you haven't solved it yet... Change line 6 to something like String[] x = s.trim().split("\\s+"); The addition here is that we first trim the string, which gets rid of leading white spaces... :)

Steffen Neumann

Level 14 , Ilfeld/ München, Deutschland

10 April 2020, 17:47

Thanks for your suggestion. I tried it, but the last condition still fails.

Basti

Level 10 , Germany

11 April 2020, 06:26

Hmm, looks pretty close to be right to me now. One more idea though - I do not use System.out.println in my code - maybe try to just use System.out.print(x[x.length-1]); on line 28 - so printing without printing a new line...

Steffen Neumann

Level 14 , Ilfeld/ München, Deutschland

11 April 2020, 13:23

Hi, no that doesn't work also. I updated my code a little bit. Maybe it's more readable.

public static void main(String[] args) throws IOException {
    BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
    String s = reader.readLine();

    //schreib hier deinen Code
    String[] x = s.trim().split("\\s+");//new String[s.length()];
    String[] orig = x;
    //x = s.trim().split("\\s+");

    for(int i = 0; i < x.length; i++){
        if(Debug.debug1){
            System.out.println(x[i]);
        }
        x[i] = x[i].replaceFirst(Character.toString(x[i].charAt(0)),Character.toString(Character.toUpperCase(x[i].charAt(0))));
        if(Debug.debug1){
            System.out.println(x[i]);
        }
    }

    //for(String y : x){
    for(int k = 0; k < x.length; k++){
        //x[k] = x[k];
        s = s.replace(orig[k],x[k]);
        //System.out.print(" " +x[k] + " ");
        if(Debug.debug2){
            System.out.println("Orignal: " + orig[k]);
            System.out.println("Modified: " + x[k]);
            System.out.println("String s: " + s);
        }
    }
    //System.out.print(x[x.length - 1]);
    /*
    for(int k = 0; k < x.length; k++){
        //s = s + x[k];
        if(Debug.debug3){
            System.out.println("New String: " + s);
        }
    }
    */
    System.out.print(s);
}

public static class Debug{
    public static boolean debug1 = false;
    public static boolean debug2 = false;
    public static boolean debug3 = false;
}

Basti

Level 10 , Germany

11 April 2020, 13:51

When you run your code, you'll see that it still prints out lower case first letters... What's line 23 supposed to do? Comment out this line and replace it with the following: if (k < x.length-1) System.out.print(x[k] + " "); else System.out.print(x[k]); And finally you can now also delete line 40.