Last condition is not passing

Question about the task

Resolved

The output is right, but the last condition is not passing. Thank you!

The first parameter of the main method is a file name.
Each line of the specified file has the following format:
name value
where [name] is a String and [value] is a double. [name] and [value] are separated by a space.

Find the sum of all the values for each name.
Display all the data, sorted by name in ascending order.
Close the streams.

Example input file:
Peterson 2 Smith 6 Baxter 1.35 Peterson 3.1

Example output:
Baxter 1.35 Peterson 5.1 Smith 6.0

Requirements:

The program must NOT read data from the console.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write to the console each name, sorted in ascending order, and the sum of all its values.

package com.codegym.task.task19.task1919; /* Calculating salaries */ import java.io.*; import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; import java.util.Map; public class Solution { public static void main(String[] args) throws IOException { //File file = new File("C:\\Users\\flori\\Desktop\\textFile1.txt"); FileReader reader = new FileReader(args[0]); BufferedReader br = new BufferedReader(reader); HashMap<String, Double> map = new HashMap<>(); String person = null; String[] personString = null; while (br.ready()){ person = br.readLine(); personString = person.split(" "); if (map.containsKey(personString[0])) { double salary1 = Double.valueOf(map.get(personString[0])); double salary2 = Double.valueOf(personString[1]); double sum = salary1 + salary2; map.replace(personString[0], salary1, sum); }else map.put(personString[0], Double.valueOf(personString[1])); } ArrayList<Double> list = new ArrayList<>(); for (Map.Entry<String, Double> pair : map.entrySet()) list.add(pair.getValue()); Collections.sort(list); for (Double valueOfPair : list) { for (Map.Entry<String, Double> pair : map.entrySet()) { if (valueOfPair.equals(pair.getValue())) System.out.println(pair.getKey() + " " + pair.getValue()); } } reader.close(); br.close(); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Cuong Tran

Level 22 , Ho Chi Minh, Viet Nam

20 June 2020, 16:12

solution

You could refer to my code. String filename = args[0]; BufferedReader readfile = new BufferedReader(new FileReader(filename)); Map<String, Double> data = new TreeMap<>(); String[] rawdata ; while(readfile.ready()) { String line = readfile.readLine(); rawdata = line.split(" "); if(data.containsKey(rawdata[0])) { String d = rawdata[0]; double salaryplus = Double.valueOf(rawdata[1]); data.replace(d, data.get(d) + salaryplus ); } else{ data.put(rawdata[0], Double.valueOf(rawdata[1])); } } for(Map.Entry<String, Double> pair : data.entrySet()) { String name = pair.getKey(); Double salary = pair.getValue(); System.out.println(name + " " + salary); } readfile.close();

Thomas

Level 41 , Bayreuth, Germany

10 June 2020, 07:24

useful

As far as I can see you save the entrysets in a list and do a sort. That's a very creative approach. I'd never had thought of that. But I do not know, how sorting (Comparable interface) is implemented (if) for entrysets. I doubt it's by the enteysets key names (but why not, that seems to be as good as everything else, I just don't know). The biggest problem you have here is using a hashmap, and that you have already noticed. Hashmaps are not meant to keep the sort order. So why not use another map that keeps the order like a treemap? This one has the advantage that it is already sorted (by the keys natural order). Then you just output the data where you now copy it into the arraylist.