Can anyone help me, Please!!!

Question about the task

Counting words

Java Core, Level 9, Lesson 5

Resolved

I can't see what is wrong I know I could take someonelese's solution but I am not learning in this way.

Read a file name from the console.
The file contains words separated by punctuation marks.
Output to the console the number of times the word "world" appears in the file.
Close the streams.

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use the FileReader constructor that takes a String argument).
The file input stream (FileReader) must be closed.
The program must output to the console the number of times the word "world" appears in the file.

package com.codegym.task.task19.task1907; /* Counting words */ import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); FileReader fileReader = new FileReader(reader.readLine()); int count = 0; int c; while(-1 != (c = fileReader.read())){ count++; } byte[] buffer = new byte[count]; int i =0 ; while (fileReader.ready()){ byte data = (byte) fileReader.read(); buffer[i] = data; i++; System.out.println(buffer[i]); } int num = 0; String theString = new String(buffer); String[] arr = theString.replaceAll("[^a-zA-Z]", " ").split(" "); for (int j =0 ; j<arr.length; j++){ if (arr[i].equals("world")) num++; System.out.println(arr[i]); } System.out.println(num); reader.close(); fileReader.close(); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

dnlklnhfr

Level 30 , Karlsruhe, Germany

29 June 2020, 14:26

Have you already tried to remove all "System.out.println"-statements except the last one? The requirement is to only show the "number of times", not more than that.

David

Level 26 , Bucharest, Romania

29 June 2020, 14:59

Doesn't work. I have tried, those lines I put them after I tried

Thomas

Level 41 , Bayreuth, Germany

29 June 2020, 15:36

You could try to add this after line 25 and then process the parts array (still in the while loop) String[] parts = fileReader.readLine().trim().split("\\p{Punct}|\\s+");

dnlklnhfr

Level 30 , Karlsruhe, Germany

29 June 2020, 15:47

solution

Ok, starting from the obvious, now I went into detail with your code. I would strongly recommend using the debugger and have a look what happens. You may have already noticed that none of your println-statements is ever executed, except the last. After line 21 your fileReader has reached its end. So all the following statements which try to access your fileReader won't find anything anymore and therefore your 'buffer', 'theString' and 'arr' are simply empty. I know your approach has its complete base on that number of characters in the file, but instead of forcefully trying to follow that byte-Array-approach (line 22) I would suggest you to try it with an ArrayList, a StringBuilder or even a simple String. So you don't need that characterCount and you can use the fileReader for what it's intended for - reading the file content. In the end you need characters anyway, so why not casting the Integers returned from fileReader.read() directly to chars? :) oh ... and please have look at line 34 & 36 - this will never work with 'i' if you declare 'j' for looping.

David

Level 26 , Bucharest, Romania

30 June 2020, 13:32

This is how I modified it. But still the same error. It works but doesn't pass the test

BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        FileReader fileReader = new FileReader(reader.readLine());
        Scanner scanner = new Scanner(fileReader);
        ArrayList<String> buffer = new ArrayList<>();
         while (scanner.hasNext()){
             String data = scanner.next();
             buffer.add(data);
         }
         int count = 0;
         for(int i = 0; i< buffer.size(); i ++){
             if (buffer.get(i).equals("world"))
                 count++;
         }
        System.out.println(count);
         scanner.close();
        reader.close();
        fileReader.close();

David

Level 26 , Bucharest, Romania

30 June 2020, 14:18

I used this and passed

scanner.useDelimiter("\\W");