Every requirement works but it doesn`t verify

Question about the task

Under discussion

When I test the code in my Intelliji it works very well for every case but it still doesn`t verify all points. Where have I gone wrong?

1. Read data from the console until the word "exit" is entered.
2. For each value (except "exit"), call the print method. If the value:
2.1. contains a period ("."), then call the print method for Double;
2.2. is greater than zero, but less than 128, then call the print method for short;
2.3. less than or equal to zero or greater than or equal to 128, then call the print method for Integer;
2.4. otherwise, call the print method for String.

Requirements:

The program must read data from the keyboard.
The program should stop reading data from the keyboard after "exit" is entered.
If the entered string contains a period (".") and can be correctly converted to a Double, the print(Double value) method should be called.
If the entered string can be correctly converted to a short and the resulting number is greater than 0, but less than 128, the print(short value) method should be called.
If the entered string can be correctly converted to an Integer and the resulting number is less than or equal to 0 or greater than or equal to 128, the print(Integer value) method should be called.
In all other cases, the print(String value) method should be called.

package com.codegym.task.task15.task1519; import java.io.BufferedReader; import java.io.InputStreamReader; import java.io.IOException; /* Different methods for different types */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); while (true) { String input = reader.readLine(); if (input.equals("exit")) { break; } try { if (input.contains(".") && (Double.parseDouble(input)>=0 || Double.parseDouble(input) < 0 )) { double d = Double.parseDouble(input); print(d); } else if (Short.parseShort(input) > 0 && Short.parseShort(input) < 128) { short s = Short.parseShort(input); print(s); } else if (Integer.parseInt(input) <= 0 || Integer.parseInt(input) >= 128) { Integer i = Integer.parseInt(input); print(i); } } catch (Exception e) { print(input); } } } public static void print(Double value) { System.out.println("This is a Double. Value: " + value); } public static void print(String value) { System.out.println("This is a String. Value: " + value); } public static void print(short value) { System.out.println("This is a short. Value: " + value); } public static void print(Integer value) { System.out.println("This is an Integer. Value: " + value); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

29 July 2020, 14:17

I couldn't find anything wrong with your code, so i would recommend removing code that is unnecessary. Often times by over complicating a task the validator gets thrown off. Try this, which functions the same exact but without superfluous code:

public static void main(String[] args) throws IOException {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

        while (true) {
            String input = reader.readLine();

            if (input.equals("exit")) {
                break;
            }

            try {

                if (input.contains(".")/* && (Double.parseDouble(input)>=0 || Double.parseDouble(input) < 0  )*/)
                {
                    double d = Double.parseDouble(input);
                    print(d);
                }

                else if (Short.parseShort(input) > 0 && Short.parseShort(input) < 128)
                {
                    short s = Short.parseShort(input);
                    print(s);
                }

                else /*if (Integer.parseInt(input) <= 0 || Integer.parseInt(input) >= 128)*/ {
                    Integer i = Integer.parseInt(input);
                    print(i);
                }

            }

            catch (Exception e) {
                print(input);
            }
        }
    }

If that does not work, try resetting the task and copy/paste the main method back in. Sometimes this will allow the task to pass.

Guadalupe Gagnon

Level 37 , Tampa, United States

29 July 2020, 14:26

Also, as a coding tip, try not to parse so many times. Every time a number is parsed to check one condition, then parsed again to check another, then parsed again to pass to a method, it is duplicated work the computer will have to do. Because you are using one value for each entry, you can pass this task by using only one parse. So, in abbreviated code:

value = readline();
try{
   number = parse(value);

  if(its a Double)
    print((Double)number);
  if(its a short)
    print((short)number);
  else
    print((Integer)number);
} catch(){
   print(value);
}