I am getting correct results but it won't verify.

Question about the task

Resolved

I am getting correct results but it won't verify. Not sure what I am missing, Verifyer is saying that I am not getting all cases of "world".

Read a file name from the console.
The file contains words separated by punctuation marks.
Output to the console the number of times the word "world" appears in the file.
Close the streams.

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use the FileReader constructor that takes a String argument).
The file input stream (FileReader) must be closed.
The program must output to the console the number of times the word "world" appears in the file.

package com.codegym.task.task19.task1907; /* Counting words Read a file name from the console. The file contains words separated by punctuation marks. Output to the console the number of times the word "world" appears in the file. Close the streams. Requirements: 1. The program must read the file name from the console (use BufferedReader). 2. The BufferedReader used for reading input from the console must be closed after use. 3. The program must read the file's contents (use the FileReader constructor that takes a String argument). 4. The file input stream (FileReader) must be closed. 5. The program must output to the console the number of times the word "world" appears in the file. */ import java.io.*; import java.sql.Array; import java.util.ArrayList; public class Solution { public static void main(String[] args) throws IOException, FileNotFoundException { BufferedReader re = new BufferedReader(new InputStreamReader(System.in)); String filename = re.readLine(); //String filename = "C:\\Users\\Alfred\\Documents\\CodeGym Data Files for exercizes\\data.txt"; re.close(); FileReader fileIn = new FileReader(filename); char[] ch = new char[(int) filename.length()]; int counter = 0; fileIn.read(ch); fileIn.close(); String fileString = String.copyValueOf(ch); String[] words = fileString.split("\\W"); for (int i = 0; i < words.length; i++) { //System.out.println(words[i]); if (words[i].equals("world")) { counter++; } } System.out.println(counter); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Nouser

Level 36 , Germany

18 October 2020, 16:47

filename.length() is the length of String filename and not the size of the file (better use FileInputStream, even if you calculate the size with long len = new File(filename).length(); you get the size in bytes and not the number of chars FileReader will read eventually) If Codegym uses a longer test file than your filename has chars, validation will fail.

AlfredW

Level 23 , Denver, United States

18 October 2020, 16:54

Thanks, Yeah I finally figured that out. But I am still having problems with it. Now my code is as below. I am getting the entire file in now. It is still telling me that I am not finding all of the instances of "world".

public class Solution {
    public static void main(String[] args) throws IOException, FileNotFoundException {
        BufferedReader re = new BufferedReader(new InputStreamReader(System.in));
        String filename = re.readLine();
        re.close();
        BufferedReader fileIn = new BufferedReader(new FileReader(filename));
        StringBuilder ch = new StringBuilder();
        while(fileIn.ready()){
            String line = fileIn.readLine();
            ch.append(line);
        }
        int counter = 0;

        fileIn.close();
        String fileString = ch.toString();
        String[] words = fileString.split("\\W+");

        for (int i = 0; i < words.length; i++) {
           //System.out.println(words[i]);
            if (words[i].equals("world") ) {
                counter++;
            }
        }
        System.out.println(counter);
    }
}

AlfredW

Level 23 , Denver, United States

18 October 2020, 17:00

Oh, I see that I am not getting an instance if the new line starts with an instance,

while(fileIn.ready()){
           String line = fileIn.readLine();
           ch.append(line);
       }

Needed to be:

while(fileIn.ready()){
          String line = fileIn.readLine();
          ch.append(line+" ");
      }

Nouser

Level 36 , Germany

18 October 2020, 17:09

yup, just wanted to post the same ;)

ch.append(line).append(" ");