here a follow up to a question I asked earlier still need help

Under discussion

follow up to my question before this I'm continuing here due to text limit in comments link to older question https://codegym.cc/help/13698 so a classmate was able to get me so far but I've lost contact with them so I'm back here for help. The code that we wrote needs to work with the demo file both of which are included line 39 of the demo program keeps causing a compile time error message ThermometerDemo.java:39: error: method setScale in class Thermometer cannot be applied to given types; therm1.setScale("F"); ^ required: no arguments found: String reason: actual and formal argument lists differ in length any ideas? here's the program that we wrote

public class Thermometer
{

   private double temp;
   private String tempScale;
   private String scale;

   public Thermometer()
   {
      temp=0;
      tempScale = "C";

   }

   public Thermometer (double temperature, String unitScale)
   {
      this.temp = temperature;
      this.tempScale = unitScale;
   }

   public double getTemp() {
      return temp;
   }

   public void setTemp(double temp) {
      this.temp = temp;
   }

   public String getTempScale() {
      return tempScale;
   }
   public String setScale(){
   return scale;
   }
   public void setTempScale(String tempScale) {
      this.tempScale = tempScale;
   }

   public void setTempSystem(double temp,String scale){
      this.temp = temp;
      this.tempScale = scale;
   }

   public String toString() {
      return temp + " degree " + tempScale;
   }

   public boolean greaters(Thermometer therm) {
      boolean isGreater = false;
      if(this.tempScale.equals(therm.tempScale)){
         if(this.temp > therm.temp){
            isGreater = true;
         }
      }else if(this.tempScale.equals("C")&& therm.getTempScale().equals("F")){
         double therm1 = this.temp;
         double therm2 = (therm.getTemp() - 32.0) * (5.0/9.0);
         if(therm1 > therm2){
            isGreater = true;
         }
      }else if(this.tempScale.equals("F")&& therm.getTempScale().equals("C")){
         double therm1 = this.temp;
         double therm2 = (therm.getTemp() * (9.0/5.0))+ 32.0;
         if(therm1 > therm2){
            isGreater = true;
         }
      }

      return isGreater;

   }

   public boolean lessers(Thermometer therm) {

      boolean isLesser = false;
      if(this.tempScale.equals(therm.tempScale)){
         if(this.temp < therm.temp){
            isLesser = true;
         }
      }else if(this.tempScale.equals("C")&& therm.getTempScale().equals("F")){
         double temp1 = this.temp;
         double temp2 = (therm.getTemp() - 32.0) *(5.0/9.0);
         if(temp1 < temp2){
            isLesser = true;
         }
      }else if(this.tempScale.equals("F")&& therm.getTempScale().equals("C")){
         double temp1 = this.temp;
         double temp2 = (therm.getTemp() *(9.0/5.0))+ 32.0;
         if(temp1 < temp2){
            isLesser = true;
         }
      }

      return isLesser;
   }

   public boolean equals(Thermometer therm) {
      boolean isEquals = false;
      if(this.tempScale.equals(therm.tempScale)){
         if(this.temp == therm.temp){
            isEquals = true;
         }
      }else if(this.tempScale.equals("C")&& therm.getTempScale().equals("F")){
         double temp1 = this.temp;
         double temp2 = convertC(therm.getTemp());
         if(temp1 == temp2){
            isEquals = true;
         }
      }else if(this.tempScale.equals("F")&& therm.getTempScale().equals("C")){
         double temp1 = this.temp;
         double temp2 = convertF(therm.getTemp());
         if(temp1 == temp2){
            isEquals = true;
         }
      }

      return isEquals;
   }

   public static double convertC(double cel){
      double temp2 = (cel - 32.0) *(5.0/9.0);
      return temp2;
   }
   public static double convertF(double far){
      double temp2 = (far *(9.0/5.0))+ 32.0;
      return temp2;
   }
}

heres the demo program that it has to work with

/*CIT111
TemperatureDemo.java*/

import java.util.Scanner;

public class ThermometerDemo{

   public static void main(String[] args)
      {
   // testing all constructors of Thermometer class and accessor and toString methods
      Thermometer therm1 = new Thermometer();
      System.out.println("Therm1 should be 0 degrees Celsius: " + therm1.toString() );
      System.out.println("Therm1 test of accessor methods: " + therm1.getTemp() + " " + therm1.getTempScale());

      Thermometer therm2 = new Thermometer(-40, "C");
      System.out.println("Therm2 should be -40 degrees Celsius: " + therm2.toString() );
      System.out.println("Therm2 test of accessor methods: " + therm2.getTemp() + " " + therm2.getTempScale());

   // testing of equals method when both thermometers have the same scale C
      if (therm1.equals(therm2))    //is therm2 (-40C) = therm1 (0C)? (FALSE)
         System.out.println("ERROR: equals method reporting true when using C scale");
      else
         System.out.println("OK: equals method reporting false when therm1 = 0 C and therm2 = -40 C");

   // testing of lessers method when both thermometers have the same scale C
      if (therm2.lessers(therm1))   //is therm1 (0C) < therm2 (-40C) (FALSE)
         System.out.println("ERROR: lessers method reporting true when using C scale");
      else
         System.out.println("OK: lessers method reporting false when using C scale");

   // testing of greaters method when both thermometers have the same scale C
      if (therm2.greaters(therm1))  //is therm1 (0C) > therm2 (-40C) (TRUE)
         System.out.println("OK: greaters method reporting true when using C scale");
      else
         System.out.println("ERROR: greaters method reporting false when using C scale");

   // testing of mutator methods -- change to two Fahrenheit values
      therm1.setTemp(32.0);
      therm1.setScale("F");
      System.out.println(therm1.toString());
      therm2.setTempSystem(0.0, "F");
      System.out.println(therm2.toString());

   // testing of equals method when both thermometers have the same scale F
      if (therm1.equals(therm2))    //is therm2 (0F) = therm 1 (32F)? (FALSE)
         System.out.println("ERROR: equals method reporting true when using F scale");
      else
         System.out.println("OK: equals method reporting false when using F scale");

   // testing of lessers method when both thermometers have the same scale F
      if (therm1.lessers(therm2))   //is therm2 (0F) < therm1 (32F)? (TRUE)
         System.out.println("OK: lessers method reporting true when using F scale");
      else
         System.out.println("ERROR: lessers method reporting false when using F scale");

   // testing of greaters method when both thermometers have the same scale F
      if (therm2.greaters(therm1))  // is therm2 (0F) > therm1 (32F)? (FALSE)
         System.out.println("OK: greaters method reporting true when using F scale");
      else
         System.out.println("ERROR: greaters method reporting false when using F scale");

   // testing equivalent temperature values using different temperature scales
    therm1.setTempSystem(0.0, "C");
    therm2.setTempSystem(32.0, "F");
    boolean result = therm1.equals(therm2);
    System.out.println("0.0C = 32.0F (True) = " + result);      //should be true

    therm1.setTempSystem(-40.0, "F");
    therm2.setTempSystem(-40.0, "C");
    result = therm1.equals(therm2);
    System.out.println("-40.0C = -40.0F (True) = " + result);

    therm1.setTempSystem(100.0, "C");
    therm2.setTempSystem(212.0, "F");
    result = therm1.equals(therm2);
    System.out.println("100.0C = 212.0F (True) = " + result);

    // testing of public static methods to convert temperatures
    System.out.println("Result of static method should be 0C: " + Thermometer.convertC(32.0));
    System.out.println("Result of static method should be 32FC: " + Thermometer.convertF(0.0));
    }
 }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Misiu

Level 41 , Gdansk, Poland

29 October 2020, 01:35

Line 39 (demo) - what method do you use here? If setScale() then this method needs to be corrected. But you have setTermScale() method too. Why not use it?

alex ayers

Level 0

29 October 2020, 04:27

the instructor wants us to use the code on line 39 how would i about correcting this because everything I've tried I just keep getting this error from the compiler messages of jgrasp ThermometerDemo.java:39: error: method setScale in class Thermometer cannot be applied to given types; therm1.setScale("F"); ^ required: no arguments found: String reason: actual and formal argument lists differ in length

horst

Level 26 , Not in list

29 October 2020, 10:12

Hooray, some actual code, that's more like it! :) It is just as Misiu pointed out: The line "therm1.setScale("F");" generates an error, because the setScale-method is not implemented correctly in the Thermometer-class. This is your current method and its problems: public String setScale() { // 1. Your method returns a String, but it should not return anything. // 2. To set a Scale, you should pass that new scale-value as a String argument return scale; // 3. Again, do not return anything, set the scale to the passed value. } 4. And please get rid of the scale-variable, your class also has a tempScale variable that does the same thing and is used throughout the rest of your code. In short: Your setScale()-method should look exactly like your already existing setTempScale()-method. By the way, I really don't mean to be condescending in any way - we are all learners here - so please don't mind me asking: Is this whole thing a little over your head? I mean, writing this specific setter correctly and understanding the error message that tells you exactly what's wrong (it expects no arguments at the moment, but in the Demo you provided it with a String, therefore your method should take a String as an argument), all in all is pretty basic Java. In my opinion, the thermometer-project is not too complicated, but it does have some subtleties that might well be beyond of someone having problems fixing a faulty setter-method. Again, I don't want to offend you, I want to understand where you are currently standing and what are the missing pieces that keep you from working it out by yourself. And honestly, I am not here to do some kind of homework or assignment for you. (I assume that this is what it is, because how else would a beginner have gotten into this rather intricate exercise?)

alex ayers

Level 0

29 October 2020, 13:44

you not doing my homework or assignment for me, I got stuck and I need help figuring out what I did wrong ok did what you said but still getting that error message what would you do in my shoes

horst

Level 26 , Not in list

29 October 2020, 14:09

Don't get me wrong, I actually do understand your situation, just a couple of months ago I would have also been lost in a task like "Create a thermometer class and implement all of its weird methods". But it's difficult to help you if I have no idea of your previous knowledge. And there is no real merit for you or me if I just fix your code and you copy it. All I wanted to say is that this is a very tough introduction to Java and you should maybe start with something more simple. But hey, since you are already here, think about practicing with CodeGym (or other great resources, feel free to ask for recommendations), and you will see that after a while you will understand how to build a class, how to create methods and so on... But back to the problem: I think you should first try to fix the errors that Misiu and me have pointed out. Assuming that you are a complete Java-beginner, here's a step-by-step guide: 1. Delete line 6 entirely (the confusing scale variable) 2. Correct your setScale-method-mixup (l. 32-37) the easy way: 2.1 Delete your current setScale-method (l.32-34) 2.2 Rename your setTempScale-method(l.35-37) to setScale (i.e. delete the "Temp" in its name) 3. Try to run the code! :)

Guadalupe Gagnon

Level 37 , Tampa, United States

29 October 2020, 14:30

@horst in regards to point 2: setScale() is used on line 39 of the test class , while getTempScale() is used on lines 14 and 17. It seems that these get/set methods are for the same Thermometer field, but whoever designed this must have learned java from a pamphlet as they should be named the same, eg: setScale() & getScale() or setTempScale() & getTempScale()

horst

Level 26 , Not in list

29 October 2020, 14:47

Definitely! That confused me at first, too, but if I didn't miss something it is just as you said. For the tempScale-variable we have a getter called getTempScale() and a setter called setScale(). There are a few more nuances in that Demo-code that make it a little bit more tedious to implement the methods, for example, the static convert-methods should probably return a String, because the output should be "0C" or "12F" and not just 0 or 12. (You can easily do this, but then you can't use the convert-methods in the rest of your code without parsing the String back to a number...) All in all I assume that at least some of the requirements are deliberately inconvenient for "learning purposes". :)

alex ayers

Level 0

29 October 2020, 14:53

@horst thanks I did what you said and it worked I definitely will come back here if I'm stuck and to study