Minesweeper (Part 14/16) - Où placer la variable score et la méthode setScore() ???

Resolved

je n'arrive vraiment pas à trouver la solution --'

package com.codegym.games.minesweeper;

import com.codegym.engine.cell.Color;
import com.codegym.engine.cell.Game;

import java.util.ArrayList;
import java.util.List;

public class MinesweeperGame extends Game {
    private static final int SIDE = 9;
    private GameObject[][] gameField = new GameObject[SIDE][SIDE];
    private int countMinesOnField;
    private static final String MINE = "\uD83D\uDCA3";
    private static final String FLAG = "\uD83D\uDEA9";
    private int countFlags;
    private boolean isGameStopped;
    private int countClosedTiles = SIDE * SIDE;
    private int score;

    @Override
    public void initialize() {
        setScreenSize(SIDE, SIDE);
        createGame();

    }

    @Override
    public void onMouseLeftClick(int x, int y) {
        openTile(x, y);
    }

    @Override
    public void onMouseRightClick(int x, int y) {
        if (!isGameStopped) markTile(x, y);
    }



    private void createGame() {
        for (int y = 0; y < SIDE; y++) {
            for (int x = 0; x < SIDE; x++) {
                boolean isMine = getRandomNumber(10) < 1;
                if (isMine) {
                    countMinesOnField++;
                }
                gameField[y][x] = new GameObject(x, y, isMine);
                setCellColor(x, y, Color.ORANGE);
            }
        }
        isGameStopped = false;
        countMineNeighbors();
        countFlags = countMinesOnField;
        score = 0;
    }

    private void gameOver() {
        showMessageDialog(Color.WHITE, "Game Over", Color.RED, 75);
        isGameStopped = true;
    }

    private void win() {
        showMessageDialog(Color.WHITE, "You Win, MF !", Color.BLUE, 75);
        isGameStopped = true;
    }

    private List<GameObject> getNeighbors(GameObject gameObject) {
        List<GameObject> result = new ArrayList<>();
        for (int y = gameObject.y - 1; y <= gameObject.y + 1; y++) {
            for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++) {
                if (y < 0 || y >= SIDE) {
                    continue;
                }
                if (x < 0 || x >= SIDE) {
                    continue;
                }
                if (gameField[y][x] == gameObject) {
                    continue;
                }
                result.add(gameField[y][x]);
            }
        }
        return result;
    }

    private void countMineNeighbors() {
        for (int y = 0; y < SIDE; y++) {
            for (int x = 0; x < SIDE; x++) {
                int countMineNeighbors = 0;
                if (gameField[y][x].isMine == false) {
                    List<GameObject> cellNeighbors = new ArrayList<GameObject>();
                    cellNeighbors = getNeighbors( gameField[y][x]);
                    for (int i = 0; i < cellNeighbors.size(); i++) {
                        if (cellNeighbors.get(i).isMine == true)
                            countMineNeighbors += 1;
                    }
                    gameField[y][x].countMineNeighbors = countMineNeighbors;
                } else continue;
            }
        }
    }

    private void openTile(int x, int y) {
        if (!isGameStopped && gameField[y][x].isOpen == false) {
            if (!gameField[y][x].isFlag) {
                if (gameField[y][x].isMine == true) {
                    setCellValueEx(x, y, Color.RED, MINE);

                    gameOver();
                }
                else {
                    int countMineNeighbors = gameField[y][x].countMineNeighbors;
                    gameField[y][x].isOpen = true;
                    setCellColor(x, y, Color.GREEN);
                    countClosedTiles -= 1;
                    score += 5;
                    if (countMineNeighbors != 0) {
                        setCellNumber(x, y, countMineNeighbors);
                        List<GameObject> cellNeighbors = new ArrayList<GameObject>();
                        cellNeighbors = getNeighbors(gameField[y][x]);
                        for (int i = 0; i < cellNeighbors.size(); i++) {
                            if (cellNeighbors.get(i).isMine == true)
                                continue;
                            if ((cellNeighbors.get(i).countMineNeighbors != 0) && (cellNeighbors.get(i).isOpen == false)) {
                                cellNeighbors.get(i).isOpen = true;
                                setCellNumber(cellNeighbors.get(i).x, cellNeighbors.get(i).y, cellNeighbors.get(i).countMineNeighbors);
                                setCellColor(cellNeighbors.get(i).x, cellNeighbors.get(i).y, Color.GREEN);
                                countClosedTiles -= 1;
                                score += 5;
                            }
                            if ((cellNeighbors.get(i).countMineNeighbors == 0) && (cellNeighbors.get(i).isOpen == false))
                                openTile(cellNeighbors.get(i).x, cellNeighbors.get(i).y);
                        }
                    } else {
                        setCellValue(x, y, "");
                        List<GameObject> cellNeighbors = new ArrayList<GameObject>();
                        cellNeighbors = getNeighbors(gameField[y][x]);
                        for (int i = 0; i < cellNeighbors.size(); i++) {
                            if (cellNeighbors.get(i).isMine == true)
                                continue;
                            if ((cellNeighbors.get(i).countMineNeighbors != 0) && (cellNeighbors.get(i).isOpen == false)) {
                                cellNeighbors.get(i).isOpen = true;
                                setCellNumber(cellNeighbors.get(i).x, cellNeighbors.get(i).y, cellNeighbors.get(i).countMineNeighbors);
                                setCellColor(cellNeighbors.get(i).x, cellNeighbors.get(i).y, Color.GREEN);
                                countClosedTiles -= 1;
                                score += 5;
                            }
                            if ((cellNeighbors.get(i).countMineNeighbors == 0) && (cellNeighbors.get(i).isOpen == false))
                                openTile(cellNeighbors.get(i).x, cellNeighbors.get(i).y);
                        }
                    }
                    setScore(score);
                    if (countClosedTiles == countMinesOnField) win();
                }

            }
        }
    }

    private void markTile(int x, int y) {
        if (gameField[y][x].isFlag == false) {
            if (gameField[y][x].isOpen == false && countFlags > 0) {
                gameField[y][x].isFlag = true;
                setCellValue(x, y, FLAG);
                setCellColor(x, y, Color.YELLOW);
                countFlags -= 1;
            }
        } else if (gameField[y][x].isFlag == true) {
            gameField[y][x].isFlag = false;
            setCellValue(x, y, "");
            setCellColor(x, y, Color.ORANGE);
            countFlags += 1;
        }
    }
}

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

30 October 2020, 13:49

Last, you don't need to check boolean values, they are already boolean values:

if(gameField[y][x].isFlag == true)
// this is the same exact statement as
if(gameField[y][x].isFlag)
// both will be true if isFlag is true

Its like checking: if(true == true) as opposed to if(true) The same thing applies to: if(gameField[y][x].isFlag == false) Here the NOT operator '!' would be preferred: if(!gameField[y][x].isFlag)

Romain

Level 26 , Paris, France

30 October 2020, 15:32

Hi, thx you for your explantation, here is my udapted code with your advice, it's shorter than before, but i don't know how use score += 5 and setScore() I tried many position, without success...

private void openTile(int x, int y) {
        if (isGameStopped || gameField[y][x].isOpen)  return ;
        if (gameField[y][x].isFlag)  return;
        if (gameField[y][x].isMine) {
           setCellValueEx(x, y, Color.RED, MINE);
           gameOver();
           return;
        }
        int countMineNeighbors = gameField[y][x].countMineNeighbors;
        gameField[y][x].isOpen = true;
        setCellColor(x, y, Color.GREEN);
        countClosedTiles -= 1;
        if (gameField[y][x].isOpen) score += 5;

        if (countMineNeighbors != 0)
            setCellNumber(x, y, countMineNeighbors);
        else
            setCellValue(x, y, "");

        List<GameObject> cellNeighbors = new ArrayList<GameObject>();
        cellNeighbors = getNeighbors(gameField[y][x]);
        for (int i = 0; i < cellNeighbors.size(); i++) {
            if (cellNeighbors.get(i).isMine == true)
                continue;
            if ((cellNeighbors.get(i).countMineNeighbors != 0) && (!cellNeighbors.get(i).isOpen)) {
                cellNeighbors.get(i).isOpen = true;
                setCellNumber(cellNeighbors.get(i).x, cellNeighbors.get(i).y, cellNeighbors.get(i).countMineNeighbors);
                setCellColor(cellNeighbors.get(i).x, cellNeighbors.get(i).y, Color.GREEN);
                countClosedTiles -= 1;
                if (cellNeighbors.get(i).isOpen) score += 5;
                setScore(score);
            }
            if ((cellNeighbors.get(i).countMineNeighbors == 0) && (!cellNeighbors.get(i).isOpen))
                openTile(cellNeighbors.get(i).x, cellNeighbors.get(i).y);
        }

        if (countClosedTiles == countMinesOnField) win();
    }

Guadalupe Gagnon

Level 37 , Tampa, United States

30 October 2020, 15:50

My last post were all tips, your code is looking a lot easier to read and debug now following your implementation of them. Here are a few more tips, as well as corrections to the logic, that should allow you to pass: #1 if countMineNeighbors is greater than 0 (or does not equal 0), after setting the cell value the method should not open up any more tiles (which it does after line 19 of the shared code above), consider using return in the if statement to prevent this. #2 once that point has been fixed, line 23-24 will logically always be false, you can safely remove these lines #3 you can actually remove lines 23-33 and leave line 34. The openTile() method already does all the needed checks that you are doing in these lines. By passing each neighbor to the openTile() method recursively all the necessary checks will be performed on each object. #4 Line 13 does not need a boolean check, the method ends if the tile wasn't opened and this means that if that line is reached then logically tile was open. #5 Your setscore() method should directly follow the setting of the score variable. #6 line 37 should be moved to directly after the set score, and also end the method after win() is called.

Romain

Level 26 , Paris, France

30 October 2020, 16:32

finally it's working, thanks for all your advice, it will help me for the future In fact, my code didn't work because of lines 23-29, i thought, when you click on a cell with a countMineNeighbors greater than 0 (or does not equal 0), unless it is circled, it reveals the neigthbors cell without mine. i did this for nothing ^^

Guadalupe Gagnon

Level 37 , Tampa, United States

30 October 2020, 16:39

Glad you solved it! And regarding the opening of additional tiles, If it revealed tiles when countMineNeighbors didn't equal 0 then all the tiles on the board not surrounded by 9 mines would open up on the first click.

Guadalupe Gagnon

Level 37 , Tampa, United States

30 October 2020, 13:46

A tip to upgrade your coding: Try to avoid tabbing your code too much. In the above code I count 7 tabs in your open tile method:

private void openTile(int x, int y) {
   if () { // 1 tab line 103
      if () {  // 2 tab line 104
         if () {} // 3 tab line 105
         else {
            if () {  // 4 tab line 116
               for () {  // 5 tab line 120
                  if ()  // 6 tab line 121
                     continue;  // 7 tab line 122

This code can very easily be refactored to remove 3 tabs right in the first few lines of code:

if (!isGameStopped && !gameField[y][x].isOpen)  return ;
if (gameField[y][x].isFlag)  return;
if (gameField[y][x].isMine) {
   setCellValueEx(x, y, Color.RED, MINE);
   gameOver();
   return;
}
int countMineNeighbors = gameField[y][x].countMineNeighbors;
gameField[y][x].isOpen = true;
setCellColor(x, y, Color.GREEN);
/*rest of the code*/

Because those first 3 boolean checks, when failed, goto the end of the method, you can just use a return statement which also ends the method and avoids putting an else statement after and tab your code. NEXT: also in the same method Lines 118-131 are the exact same as 135-148. You did this to set the cell value differently on lines 117 and134 depending on what countMineNeighbors was. The reason to avoid this is if there was a bug in those 2 duplicate sections you would have to make the same bug fix twice. It would make your code easier to read and debug if you did this instead:

//erase lines 118-133
if (countMineNeighbors != 0)
   setCellNumber(x, y, countMineNeighbors);
else
   setCellValue(x, y, "");
List<GameObject> cellNeighbors = new ArrayList<GameObject>();
cellNeighbors = getNeighbors(gameField[y][x]);
/*lines 137-148*/

With the above two tips your code would only be tabbed a total of 3 time

Vincenzo Seggio

Level 28

30 October 2020, 12:14

I put score += 5 and setScore(score) in the else partt.

else {
                setCellNumber(x, y, gameObject.countMineNeighbors);
                score += 5;
                setScore(score);
            }

Romain

Level 26 , Paris, France

30 October 2020, 15:41

thx but i don't understant where put it in my code, i just answer to Guadalupe Gagnon, with a updapted code, if you have an idea, i will thx you sorry for bad english