Why do I fail the test?

Question about the task

Resolved

The output seems correct but I fail the test with 2 errors 1) The run method does not display the required text. 2) If a player wins, his or her run method should display [getName() + ":won!"]. For example: [Jones:won!]. but my output is: Gates:Start Game Smith:Start Game Gates:Gather resources Gates:Grow economy Smith:Gather resources Gates:Kill enemies Gates:won! Smith:lost Jones:lost What am I missing?

Three people play the game. Each player (Gamer) is characterized by two parameters: last name (name) and the actions-per-second (rating).
Display the actions taken and determine the winner and the losers.
Let's begin...
1. Figure out what the program does.
1.1. List<String> actions stores the sequence of actions performed by each player from 0 to the last.
1.2. isWinnerFound indicates whether the winner has been found.
1.3. The sleep method throws an InterruptedException and takes a long argument.
1.4. The players play independently of each other.
2. Implement the run method so that for each player:
2.1. At regular intervals (1000ms/rating), the actions specified in the actions list are displayed.
2.2. All text begins with the player's name (getName()), followed by a colon, and then the text itself.

Example:[Smith:Game start].

2.3. When a player has performed all of the actions in the actions list, he or she wins. Display [getName() + ":won!"].
2.4. When the winner is found, the game ends, and the remaining players have lost. For these players, display [getName() + ":lost"].

Don't display the square brackets ("[]").

Requirements:

At regular intervals (1000ms/rating), the Gamer class's run method should display the player's last name (getName()), followed by a colon, and then the text in OnlineGame.actions. Example: [Smith:Game start].
When all the game actions have been completed and the winner has not yet been found, the run method must set the flag OnlineGame.isWinnerFound to true (to inform the others that it is the winner).
If a player wins, his or her run method should display [getName() + ":won!"]. For example: [Jones:won!].
The run methods of all players who did not win (those who were interrupted) should display [getName() + ":lost"]. For example: [Gates:lost]
The run method must not throw an exception when it is interrupted.

package com.codegym.task.task16.task1627; import java.util.ArrayList; import java.util.List; public class Solution { public static void main(String[] args) throws InterruptedException { OnlineGame onlineGame = new OnlineGame(); onlineGame.start(); } public static class OnlineGame extends Thread { public static volatile boolean isWinnerFound = false; public static List<String> actions = new ArrayList<>(); static { actions.add("Start Game"); actions.add("Gather resources"); actions.add("Grow economy"); actions.add("Kill enemies"); } protected Gamer gamer1 = new Gamer("Smith", 3); protected Gamer gamer2 = new Gamer("Jones", 1); protected Gamer gamer3 = new Gamer("Gates", 5); public void run() { gamer1.start(); gamer2.start(); gamer3.start(); while (!isWinnerFound) { } gamer1.interrupt(); gamer2.interrupt(); gamer3.interrupt(); } } public static class Gamer extends Thread { private int rating; public Gamer(String name, int rating) { super(name); this.rating = rating; } @Override public void run() { while (!OnlineGame.isWinnerFound) { try { for (String action : OnlineGame.actions) { Thread.sleep((long)1000 / rating); System.out.println(Thread.currentThread().getName() + ":" + action); if (action.equals("Kill enemies")) { System.out.println(Thread.currentThread().getName() + ":won!"); OnlineGame.isWinnerFound = true; break; } } } catch (InterruptedException e) { System.out.println(Thread.currentThread().getName() + ":lost"); } } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

24 December 2020, 14:28

useful

In the run method: - Remove the while loop. There is no need to loop here as each player should only do each action only 1 time unless interrupted - Get rid of the 'if' check. You don't need it. Logically if a player has progressed through all actions then the for loop would be finished. You can simply set the game as finished and print the "won!" after the loop without having to check that it is the last condition. Also, lets say a year later you updated this game to be less violent by renaming the "kill enemies" actions. Without that check it would be as simple as just changing the name of the action, or actions if you do more than one. If you hardcode checks like this into your code then an upgrade like that could take quite a bit longer as you went line by line to remove all the hard coded references. You can also use getName() instead of Thread.currentThread.getName() as no redundancy exists in this code that you would need to specify the current Thread. It isn't more right or wrong one way or the other, though it is less typing the first way

Liliane Top Backend Developer at Procura

26 December 2020, 11:16

Thanks so much for helping me! 1) I removed the while loop. I now understand that we loop over the action list and if its get interrupted we jump to the catch otherwise the first thread to finish the loop is the winner. We declare the winner 2) Hence I can get rid of the if-check 3) Great tip about the redundancy (I also ordered the book " clean code" But My code is still failing the test: public void run() { try { for (String action : OnlineGame.actions) {//each player will do the action once unless interrupted Thread.sleep(1000 / rating); System.out.println(getName() + ":" + action); } OnlineGame.isWinnerFound = true; System.out.println(getName() + ":won!"); } catch (InterruptedException e) { System.out.println(getName() + ":lost"); } why? The feedback is very confusing as it doesn't say what is wrong only again generic that the run method does not display the required text which is does!

Liliane Top Backend Developer at Procura

26 December 2020, 11:20

The other error : If a player wins, his or her run method should display [getName() + ":won!"]. For example: [Jones:won!]. I resolved it by adding the if-check if(!OnlineGame.isWinnerFound) { OnlineGame.isWinnerFound = true; System.out.println(getName() + ":won!"); }

Liliane Top Backend Developer at Procura

26 December 2020, 11:28

solution

I figured it out. It had nothing to do with the logic of my code but that I changed the text of the first action to "Game start" as per the validation suggestion but it should be Start game. Something they should change as it created unnecessary confusion.