Where did I go wrong?

Question about the task

Singleton

Java Core, Level 4, Lesson 8

Under discussion

I do not know what I did wrong here. Seems simple enough.

A class is a singleton if it lets you create just one object of its type.

Implement the Singleton pattern:
1. Create a Singleton class in a separate file.
2. Add a static getInstance() method to it.
3. The getInstance method must return the same Singleton object any time the getInstance method is called.
4. Think about how you can prevent the creation of additional instances of this class.
5. Make all the constructors of the Singleton class private.
6. As a result, it should ONLY be possible to create an object (instance of this class) using the getInstance method.

Requirements:

The Singleton class must be in a separate file.
The Singleton class should prevent Singleton objects from being created outside the class.
The Singleton class must have a private static Singleton field instance.
The Singleton class must implement the public static getInstance method, which returns the value of the field instance.
The getInstance method must ALWAYS return the same object.

package com.codegym.task.task14.task1421; /* Singleton */ public class Solution { public static void main(String[] args) { } } class Singleton { public static final Singleton one = new Singleton(); public static Singleton getInstance() { return one; } private Singleton() { } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

wassim lagnaoui

Level 22 , Denton, United States

27 December 2021, 19:30

From the requirements here what you did wrong : The instance one should be private instead of public : -- private static final Singleton one = new Singleton();

Guadalupe Gagnon

Level 37 , Tampa, United States

27 December 2021, 18:15

"1. Create a Singleton class in a separate file." The first condition does state that the Singleton class needs to be in a separate file. You can just right click the task folder and add the class. I added pictures in both intelliJ and the codegym website:

public enum WaysToDie

Level 23 , Denver, United States

27 December 2021, 19:43

Thank you for your help, I tried your solution, but it is still failing the same tests.

Guadalupe Gagnon

Level 37 , Tampa, United States

27 December 2021, 20:33

Did you rename the variable to the correct 'instance' instead of 'one'? It does say that it should be private static and not also final