help, i don't know what the problem is.

Question about the task

Minesweeper (Part 13/16)

Games, Level 0, Lesson 0

Resolved

😵

The game is won when the number of remaining hidden cells is equal to the number of mines. To count the number of hidden cells, we'll introduce another variable whose initial value is equal to the total number of cells on the playing field. The value of this variable will decrease as the cells are revealed. When it becomes equal to the number of mines, the game is won.

In the event of a win, our game currently does nothing, but it should. It's time to fix that.

Let's write a win() method that stops the game and displays a beautiful congratulatory message to the winner.

Run the game and check that the win() method is run when the player wins.

Note that the win() method is called if the number of hidden cells is equal to the number of mines on the field. However, if the last revealed cell is a mine, then the method must not be called.

Requirements:

The MinesweeperGame class must have a private int countClosedTiles field that is initialized to SIDE * SIDE when it is declared.
The openTile(int, int) method must decrease the countClosedTiles field by 1 if the gameField element's isOpen flag is set.
The MinesweeperGame class must have a private void win() method.
The win() method must set the isGameStopped variable to true.
The win() method must call the showMessageDialog(Color, String, Color, int) method.
The openTile(int, int) method must call the win() method if the number of hidden cells is equal to the number of mines on the field and the last revealed cell is not a mine.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class MinesweeperGame extends Game{ private static final int SIDE=9; // 地图大小 private GameObject[][] gameField = new GameObject[SIDE][SIDE]; // 地图 private int countMinesOnField;// 场上的地雷总数 private int countClosedTiles = SIDE*SIDE; // 未打开的格子总数 private static final String MINE = "\uD83D\uDCA3"; // 地雷 private static final String FLAG = "\uD83D\uDEA9"; // 旗子 private int countFlags; private int [][] dim = {{-1, 0}, {0, -1}, {0, 1}, {1, 0}, {-1, -1}, {-1, 1}, {1, -1}, {1, 1}}; private boolean isGameStopped; @Override // 点击鼠标左键 public void onMouseLeftClick(int x, int y){ // 调用 openTile()函数显示数字或地雷 openTile(x, y); } private void openTile(int x, int y){ if(isGameStopped==true || gameField[y][x].isFlag==true || gameField[y][x].isOpen==true){ return; } gameField[y][x].isOpen = true; --countClosedTiles; setCellColor(x, y, Color.GREEN); // 判断是否是雷 if(gameField[y][x].isMine==true){ setCellValueEx(x, y, Color.RED, MINE); gameOver(); return; } else { // 周围没有地雷 if(gameField[y][x].countMineNeighbors==0){ setCellValue(x, y, ""); for(int i=0; i<8; i++){ int x1 = x + dim[i][0]; int y1 = y + dim[i][1]; if(x1>=0&&x1<SIDE&&y1>=0&&y1<SIDE){ if(gameField[y1][x1].isOpen==false){ openTile(x1, y1); } } } } else { setCellNumber(x, y, gameField[y][x].countMineNeighbors); } } if(countClosedTiles == countMinesOnField && gameField[y][x].isMine==false){ win(); } } @Override // 鼠标右击 public void onMouseRightClick(int x, int y){ markTile(x, y); } private void markTile(int x, int y){ if(isGameStopped==true){ return; } // 当前格子没有显示 / 场上旗子用完并且该格子不是旗子 if(gameField[y][x].isOpen==true || countFlags==0 && gameField[y][x].isFlag==false){ // 啥也不干 } else { if(!gameField[y][x].isFlag){ gameField[y][x].isFlag = true; countFlags--; setCellValue(x, y, FLAG); setCellColor(x, y, Color.YELLOW); } else { gameField[y][x].isFlag = false; countFlags++; setCellValue(x, y, ""); setCellColor(x, y, Color.ORANGE); } } } private void gameOver(){ isGameStopped = true; showMessageDialog(Color.RED, "GameOver", Color.YELLOW, 80); } private void win(){ isGameStopped = true; showMessageDialog(Color.YELLOW, "You Wins!", Color.RED, 80); } // 创造cell 坐标颜色计算总的地雷数重点 i, j 的点对应坐标是 j,i private void createGame(){ isGameStopped = false; int mineNum = 0; for(int i=0; i<SIDE; i++){ mineNum = getRandomNumber(10); for(int j=0; j<SIDE; j++){ boolean boom = false; if(mineNum == j){ boom = true; countMinesOnField++; } gameField[i][j] = new GameObject(j, i, boom); setCellColor(j, i, Color.ORANGE); } } countMineNeighbors(); countFlags = countMinesOnField; } // 计算每个cell 周围的地雷数目 private void countMineNeighbors(){ for(int i=0; i<SIDE; i++){ for(int j=0; j<SIDE; j++){ if(gameField[i][j].isMine == false){ gameField[i][j].countMineNeighbors = getNeighbors(gameField[i][j]); } } } } // 获取每个非地雷点周围的地雷数 private int getNeighbors(GameObject gameObject){ int x = gameObject.y; int y = gameObject.x; int sum = 0; for(int i=0; i<dim.length; i++){ int x1 = x + dim[i][0]; int y1 = y + dim[i][1]; if(x1>=0&&x1<SIDE&&y1>=0&&y1<SIDE){ if(gameField[x1][y1].isMine==true){ sum++; } } } return sum; } // 初始化 public void initialize(){ setScreenSize(SIDE, SIDE); createGame(); } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Lisa L

Level 47 , Nuremberg, Germany

19 March 2022, 09:56

The openTile method is called every time a tile got clicked. It then decides what it has to do, open a tile, opem even more tiles or ignore the click. Only when a tile has opened the countClosedTiles value should get decremented. So you'd need to move that statement (line 28) to another place in your code.

Anonymous #10958860

Level 1 , China, China

19 March 2022, 11:28

I've just tried a couple of places and it doesn't seem to work. I don't know where to put that code😵

Lisa L

Level 47 , Nuremberg, Germany

19 March 2022, 11:37

I'd try to delete line 27 and move line 28 between lines 46,47

Anonymous #10958860

Level 1 , China, China

19 March 2022, 11:48

I just tried and failed. Also, I don't understand why line 27 needs to be deleted

Lisa L

Level 47 , Nuremberg, Germany

19 March 2022, 12:06

useful

You're absolutely right. I told nonsense before. Forget everything. I should have thought more before writing. Problem maybe is, that you do not make use of the getNeighbors method you coded before try

for (GameObject neighbor : getNeighbors(gameField[y][x]))
    if (!neighbor.isOpen)
        openTile(neighbor.x, neighbor.y);

instead of lines 41 - 48 You also coud save a reverence to the current gameField in a variable and that way you won't need to write gameField[y][x] for each access.

GameObject cell = gameField[y][x];

btw, you do not need to use an array to code all the positions for the neighbors. You just could use loops for that.

private List<GameObject> getNeighbors(GameObject gameObject) {
    List<GameObject> result = new ArrayList<>();
    for (int y = gameObject.y - 1; y <= gameObject.y + 1; y++) {
        for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++) {
            if (y < 0 || y >= SIDE) {
                continue;
            }
            if (x < 0 || x >= SIDE) {
                continue;
            }
            if (gameField[y][x] == gameObject) {
                continue;
            }
            result.add(gameField[y][x]);
        }
    }
    return result;
}

Anonymous #10958860

Level 1 , China, China

19 March 2022, 12:21

Yeah, I think it's great to code that way, let me try and see if I can fix it

Anonymous #10958860

Level 1 , China, China

19 March 2022, 12:32

Thank you so much, after trying so many times, I just modified the code for getNeighbors() as you suggested and successfully passed the test