Issue with validator - the program ran too long and was closed!

Question about the task

Resolved

In IntelliJ IDEA , this code runs without any issues, but when I send task for validation, result is: The program ran too long and was closed!

package com.codegym.task.task18.task1801; import java.io.FileInputStream; import java.io.InputStream; import java.util.Scanner; /* Maximum byte */ public class Solution { public static void main(String[] args) throws Exception { Scanner console = new Scanner(System.in); System.out.print("Please enter filename: "); String fileName = console.nextLine(); try( InputStream fStream = new FileInputStream(fileName) ) { int maxByte = 0; int currByte; while((currByte = fStream.read()) != -1){ if (currByte > maxByte) maxByte = currByte; } System.out.println("Max byte is: " + maxByte); } catch (Exception e){ throw e; } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

EL POP'S CO

Level 4 , Cameroon

17 June 2023, 16:09

Please, help me for learn Java. Thanks.

Guadalupe Gagnon

Level 37 , Tampa, United States

15 June 2023, 15:47

#1 When tasks say to output something to the console they absolutely mean to only output that specific thing. Any additional output is an automatic failure. This means, in this task, that line15 and the "Max byte is: " of line 26 are going to cause a failure. #2 I don't 100% know why the validator says that the code runs too long, but my best guess as to the most likely reason is because when the task says to use a specific class, as in the second requirement saying: "Use a FileInputStream to read from the file" It literally means to use: FileInputStream fStream = new FileInputStream(fileName) Try modifying your code to do this and see if that solves the issue.

Vadim “迪姆哥”

Level 35 , Kazakhstan

17 June 2023, 16:27

solution

#1 Correct, ty🤝 #2 is not the case, it runs too long because of

while((currByte = fStream.read()) != -1)

then I corrected it to

while((currByte = fStream.read()) > 0)

which is strange, cuz Java offitial documentation said about .read() method: Returns: the next byte of data, or -1 if the end of the file is reached.

Thomas

Level 41 , Bayreuth, Germany

18 June 2023, 18:15

I can not second your assumption that the while condition is the culprit as I validated exactly that way

public static void main(String[] args) throws Exception {
    int
            max = Byte.MIN_VALUE,
            curr;

    try (BufferedReader console = new BufferedReader(new InputStreamReader(System.in));
         InputStream in = new FileInputStream(console.readLine())) {

        while ((curr = in.read()) != -1)
            max = curr > max ? curr : max;
    }

    System.out.println(max);
}

But I also can not tell you another explanation.

Vadim “迪姆哥”

Level 35 , Kazakhstan

15 June 2023, 15:22

The validator have 2 issues on my code: 1. Condition bellow lead to error: the program ran too long and was closed! But at the same time in IntelliJ IDEA program finished it execution fast, without any long run.

while((currByte = fStream.read()) != -1)

2. The third condition: "The program should display the maximum byte read from the file." isn't passes validation, even my code have command for print out the maxByte variable:

System.out.println("Max byte is: " + maxByte);