Can't figure out why this won't pass validation

Question about the task

Under discussion

I ran this using the example in the conditions and my output matches the example output. I'm not sure what I am missing here.

Read from the console the name of a file containing HTML.

Example:
Info about Leela Leela Turanga
Supergirl

The main method's first parameter is a tag name. For example, "span".
Display all tags that match the specified tag.
The order should match their order in the file, each tag on a new line.
The number of spaces, newline characters (\n), or carriage returns (\r) does not affect the result.
The file does not have a CDATA tag. Each opening tag has a separate closing tag, and there are no self-closing tags.
Tags may have nested tags.

Example output:
Leela Turanga Leela Turanga Super girl

Tag templates:
<tag>text1</tag> <tag text2>text1</tag> <tag text2>text1</tag>

text1 and text2 can be empty

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must write to the console all the tags that match the tag specified by the argument passed to the main method.

package com.codegym.task.task19.task1918; /* Introducing tags */ import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; public class Solution { public static void main(String[] args) throws IOException { BufferedReader consoleReader = new BufferedReader(new InputStreamReader(System.in)); BufferedReader reader = new BufferedReader(new FileReader(consoleReader.readLine())); consoleReader.close(); String data = ""; String line = reader.readLine(); while (line != null) { data += line; line = reader.readLine(); } reader.close(); String openingTag = "<" + args[0]; String closingTag = "</" + args[0] + ">"; String alpha = "α"; String omega = "Ω"; data = data.replaceAll(openingTag, alpha); data = data.replaceAll(closingTag, omega); data = data.substring(data.indexOf(alpha)); while (data.contains(alpha)) { int alphaCount = 0; int omegaCount = 0; for (int i = 0; i < data.length(); i++) { if (alpha.equals(String.valueOf(data.charAt(i)))) { alphaCount++; } else if (omega.equals(String.valueOf(data.charAt(i)))) { omegaCount++; } if (alphaCount > 0 && alphaCount == omegaCount) { String tags = data.substring(0, i + 1); tags = tags.replaceAll(alpha, openingTag); tags = tags.replaceAll(omega, closingTag); System.out.println(tags); data = data.replaceFirst(alpha, ""); if (data.contains(alpha)) { data = data.substring(data.indexOf(alpha)); } } } } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Fadi Alsaidi

Level 34 , Carrollton, TX, USA

19 April 2020, 18:31

You need to try this more rigid example posted by a great user. Code GYM gave and easy example, as you already seen a lot of people are getting the correct output. try the below and if you are able to get the correct answer then you should be good to go. Tips: 1- make sure your starting index is the very next open tag every single time . Don't start from the last closed tag unless you use it as a starting point to find the next open tag. 2- make sure you account for nested tags

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 16:39

Your error is a missing break statement. Below I pasted a modified version of your code with a system of debugging that I use:

public class Solution {
    public static class Debug{
        public static boolean flag(){
            return true;
        }
    }

    public static void main(String[] args) throws IOException {
        String fileName;
        if(Debug.flag()){
            args = new String[]{"span"};
            fileName = "C:\\Users\\lupeh\\Desktop\\temp\\test.txt";
        }
        else fileName = new BufferedReader(new InputStreamReader(System.in)).readLine();

        BufferedReader reader = new BufferedReader(new FileReader(fileName));

        String data = "";
        String line;
        while ((line = reader.readLine()) != null)
            data += line;

        reader.close();

        if(Debug.flag())System.out.println("Data in full:\n\t" + data);

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 16:39

String openingTag = "<" + args[0];
        String closingTag = "</" + args[0] + ">";
        char alpha = 'α';
        char omega = 'Ω';
        data = data.replaceAll(openingTag, ""+alpha);
        data = data.replaceAll(closingTag, ""+omega);
        data = data.substring(data.indexOf(alpha));
        StringBuilder sb = new StringBuilder();
        if(Debug.flag()){
            System.out.println("Data with tags added + before while loop:\n\t" + data);
            System.out.println("*********************************************");
        }
        while (data.contains(""+alpha)) {
            if(Debug.flag()) System.out.println("New line to test\n\t" + data);
            int alphaCount = 0;
            int omegaCount = 0;
            for (int i = 0; i < data.length(); i++) {
                if (alpha == data.charAt(i)) {
                    alphaCount++;
                    if(Debug.flag()) System.out.println("\t Alpha char found, alpha count now: " + alphaCount);
                } else if (omega == data.charAt(i)) {
                    omegaCount++;
                    if(Debug.flag()) System.out.println("\t Alpha char found, alpha count now: " + omegaCount);
                }
                if (alphaCount > 0 && alphaCount == omegaCount) {
                    String tags = data.substring(0, i + 1);
                    tags = tags.replaceAll(""+alpha, openingTag);
                    tags = tags.replaceAll(""+omega, closingTag);
                    if(Debug.flag())
                        System.out.println("\tLine added: [" + tags +"]");
                    sb.append(tags+"\n");
                    data = data.replaceFirst(""+alpha, "");
                    if (data.contains(""+alpha)) {
                        data = data.substring(data.indexOf(alpha));

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 16:39

}
                }
            }
        }
        if(Debug.flag()){
            System.out.println("Loop End");
            System.out.println("*********************************************");
        }
        System.out.println(sb);

    }

}

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 16:41

change line 12 (of the very first post) to the file path on your computer of where you have the example input and change that by copy and pasting one tag and closing tag to right after the first open tag: so copy this: openspangirlclosespan and paste it in: <spanHERE xml:lang="en" (i hope that makes sense, this text box uses HTML and i can't just copy and paste exactly what i mean in because it is all chopped off) when you accomplish that, run this code and see if you can step through what is going on and spot the issue.