Problem with the last requirement

Question about the task

Resolved

Can anyone explain to me why my solution is not able to satisfy the last requirement? Is there anything wrong with the way I call close() on the outputstream?

Read 3 file names from the console.
Write the contents of the second file to the first file, and then append the contents of the third file to the first file.
Close the streams.

Requirements:

The program should read a file name three times from the console.
Create an output stream for the first file. For the other two, create input streams.
The contents of the second file must be copied to the first file.
The contents of the third file must be appended to the first file (after the second file has been written to the first file).
The file streams must be closed.

package com.codegym.task.task18.task1818; /* Two in one */ import java.io.*; public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String name1 = reader.readLine(); String name2 = reader.readLine(); String name3 = reader.readLine(); reader.close(); FileOutputStream out1 = new FileOutputStream(name1); FileInputStream in2 = new FileInputStream(name2); FileInputStream in3 = new FileInputStream(name3); byte[] buffer = new byte[in2.available()]; int count = in2.read(buffer); out1.write(buffer, 0, count); buffer = new byte[in3.available()]; count = in3.read(buffer); out1.write(buffer, 0, count); out1.close(); in2.close(); in3.close(); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Dmitrii

Level 38 , Saint Petersburg, Russian Federation

5 June 2019, 11:59

useful

Im not sure why does it think u r not closing streams, i'd suggest try-with-resources Other than that, test might be giving u a wrong info on what is wrong, as i can see u r not appending the third file, but writing it at the begining

out1.write(buffer, 0, count);

Also consider either closing the first input stream before u write from the second, or using flush(), that might be a problem too

robin

Level 23 , Lublin, Poland

5 June 2019, 12:20

solution

Thank you for your answer and for all the suggestions. Unfortunately none of these seem to work :/ Perhaps I'll try some different approach to this task. EDIT: I was wrong in the way I tried to implement try-with-resources. The problem was that I did it only for the out1 FileOutputStream (I didn't know I could use more than 1 definition in the parentheses immediately following 'try' by separating them with semicolons). When I did define all three streams next to 'try', the task satisfied the last requirement and I got a PASS! :D So, thank you for the useful feedback, Dmitrii! You were right.

Thang Za Thang

Level 18 , Melbourne, Australia

5 August 2020, 02:45

Like so: BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String file1 = reader.readLine(); String file2 = reader.readLine(); String file3 = reader.readLine(); reader.close(); try (FileOutputStream outputStream = new FileOutputStream(file1); FileInputStream inputStream1 = new FileInputStream(file2); FileInputStream inputStream2 = new FileInputStream(file3); ){ byte[] buffer = new byte[inputStream1.available()]; int count = inputStream1.read(buffer); outputStream.write(buffer, 0, count); // Contents of the file2 is written to the first file, file1. //buffer buffer = new byte[inputStream2.available()]; count = inputStream2.read(buffer); outputStream.write(buffer, 0, count); // Contents of the file3 is written to the first file, file1. outputStream.close(); inputStream1.close(); inputStream2.close(); }